Enable checkstyle rule to catch variables that hide fields

Enable the checkstyle "HiddenFields" rule and fix any issues
that it detects.  Suppress these violations for parameters
to setters and constructors.

Added support for the checkstyle comment suppression module
// CHECKSTYLE:OFF and //CHECKSTYLE:ON are now
supported.

Suppressed HiddenField checks for net.onrc.onos.core.packet.*
rather than fix them.  These APIs are designed to
require formal parameters and local members having
the same name.

Change-Id: Ibc057603a934842d9c9b9b668f55bc5f5519e7f6
diff --git a/src/main/java/net/onrc/onos/apps/bgproute/BgpRoute.java b/src/main/java/net/onrc/onos/apps/bgproute/BgpRoute.java
index 303f198..78f7a61 100644
--- a/src/main/java/net/onrc/onos/apps/bgproute/BgpRoute.java
+++ b/src/main/java/net/onrc/onos/apps/bgproute/BgpRoute.java
@@ -90,7 +90,8 @@
 
     private String bgpdRestIp;
     private String routerId;
-    private String configFilename = "config.json";
+    private static final String DEFAULT_CONFIG_FILENAME = "config.json";
+    private String currentConfigFilename = DEFAULT_CONFIG_FILENAME;
 
     private static final short ARP_PRIORITY = 20;
 
@@ -309,11 +310,11 @@
 
         String configFilenameParameter = context.getConfigParams(this).get("configfile");
         if (configFilenameParameter != null) {
-            configFilename = configFilenameParameter;
+            currentConfigFilename = configFilenameParameter;
         }
-        log.debug("Config file set to {}", configFilename);
+        log.debug("Config file set to {}", currentConfigFilename);
 
-        readConfiguration(configFilename);
+        readConfiguration(currentConfigFilename);
     }
 
     @Override
@@ -356,7 +357,7 @@
         response = response.replaceAll("\"", "'");
         JSONObject jsonObj = (JSONObject) JSONSerializer.toJSON(response);
         JSONArray ribArray = jsonObj.getJSONArray("rib");
-        String routerId = jsonObj.getString("router-id");
+        String inboundRouterId = jsonObj.getString("router-id");
 
         int size = ribArray.size();
 
@@ -383,7 +384,7 @@
                 continue;
             }
 
-            RibEntry rib = new RibEntry(routerId, nexthop);
+            RibEntry rib = new RibEntry(inboundRouterId, nexthop);
 
             try {
                 ribUpdates.put(new RibUpdate(Operation.UPDATE, p, rib));
diff --git a/src/main/java/net/onrc/onos/apps/bgproute/Prefix.java b/src/main/java/net/onrc/onos/apps/bgproute/Prefix.java
index 0d297bf..49bbcac 100644
--- a/src/main/java/net/onrc/onos/apps/bgproute/Prefix.java
+++ b/src/main/java/net/onrc/onos/apps/bgproute/Prefix.java
@@ -50,10 +50,11 @@
         }
     }
 
-    private byte[] canonicalizeAddress(byte[] address, int prefixLength) {
-        byte[] result = new byte[address.length];
+    private byte[] canonicalizeAddress(byte[] addressValue,
+                                       int prefixLengthValue) {
+        byte[] result = new byte[addressValue.length];
 
-        if (prefixLength == 0) {
+        if (prefixLengthValue == 0) {
             for (int i = 0; i < MAX_BYTES; i++) {
                 result[i] = 0;
             }
@@ -61,18 +62,18 @@
             return result;
         }
 
-        result = Arrays.copyOf(address, address.length);
+        result = Arrays.copyOf(addressValue, addressValue.length);
 
         //Set all bytes after the end of the prefix to 0
-        int lastByteIndex = (prefixLength - 1) / Byte.SIZE;
+        int lastByteIndex = (prefixLengthValue - 1) / Byte.SIZE;
         for (int i = lastByteIndex; i < MAX_BYTES; i++) {
             result[i] = 0;
         }
 
-        byte lastByte = address[lastByteIndex];
+        byte lastByte = addressValue[lastByteIndex];
         byte mask = 0;
         byte msb = (byte) 0x80;
-        int lastBit = (prefixLength - 1) % Byte.SIZE;
+        int lastBit = (prefixLengthValue - 1) % Byte.SIZE;
         for (int i = 0; i < Byte.SIZE; i++) {
             if (i <= lastBit) {
                 mask |= (msb >> i);