| commit | 53ad5e393eeab71fada318c42c416c2aaadcba9c | [log] [tgz] |
|---|---|---|
| author | Pavlin Radoslavov <pavlin@onlab.us> | Thu Apr 10 14:24:26 2014 -0700 |
| committer | Pavlin Radoslavov <pavlin@onlab.us> | Thu Apr 10 14:24:26 2014 -0700 |
| tree | 181e79bb0325de4d0cacbcbe72e7f5aef74e24f0 | |
| parent | 952a976d588cd1b28d302dd0f5ec85bca0487dee [diff] |
Fix issues found by FindBugs: SS_SHOULD_BE_STATIC and SIC_INNER_SHOULD_BE_STATIC http://findbugs.sourceforge.net/bugDescriptions.html#SS_SHOULD_BE_STATIC http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC Change-Id: I9966b69a5a10fecb29725369859f03f606fedadc
diff --git a/src/main/java/net/onrc/onos/core/intent/runtime/PathCalcRuntimeModule.java b/src/main/java/net/onrc/onos/core/intent/runtime/PathCalcRuntimeModule.java index 4ba9b54..9ef1a1f 100755 --- a/src/main/java/net/onrc/onos/core/intent/runtime/PathCalcRuntimeModule.java +++ b/src/main/java/net/onrc/onos/core/intent/runtime/PathCalcRuntimeModule.java
@@ -55,7 +55,7 @@ } } - class PerfLogger { + static class PerfLogger { private LinkedList<PerfLog> logData = new LinkedList<>(); public PerfLogger(String logPhase) {
diff --git a/src/main/java/net/onrc/onos/core/packet/BPDU.java b/src/main/java/net/onrc/onos/core/packet/BPDU.java index ce0d9a2..38e979c 100644 --- a/src/main/java/net/onrc/onos/core/packet/BPDU.java +++ b/src/main/java/net/onrc/onos/core/packet/BPDU.java
@@ -31,7 +31,7 @@ TOPOLOGY_CHANGE; } - private final long destMac = 0x0180c2000000L; // 01-80-c2-00-00-00 + private static final long DEST_MAC = 0x0180c2000000L; // 01-80-c2-00-00-00 // TODO - check this for RSTP private LLC llcHeader; @@ -134,6 +134,6 @@ } public long getDestMac() { - return destMac; + return DEST_MAC; } }