| commit | 45614c55b0926d8810416826fe8cfe1d1642c58a | [log] [tgz] |
|---|---|---|
| author | Ray Milkey <ray@onlab.us> | Mon Apr 07 16:30:54 2014 -0700 |
| committer | Ray Milkey <ray@onlab.us> | Mon Apr 07 16:30:54 2014 -0700 |
| tree | d177b14381571e6a3533c3253c735b705443dbdc | |
| parent | b5716c5f0eab661830069fdfb5b230d3dcad1e95 [diff] |
Enable checkstyle rule to disallow C style array declarations (byte foo[]) and fix instances of it. Change-Id: I34499c9f28bae5e2f2c5c47330768de76439e3d5
diff --git a/src/main/java/net/onrc/onos/core/intent/PathIntent.java b/src/main/java/net/onrc/onos/core/intent/PathIntent.java index e541454..633fe8b 100644 --- a/src/main/java/net/onrc/onos/core/intent/PathIntent.java +++ b/src/main/java/net/onrc/onos/core/intent/PathIntent.java
@@ -15,7 +15,7 @@ } public static String createNextId(String currentId) { - String parts[] = currentId.split("___"); + String[] parts = currentId.split("___"); return String.format("%s___%d", parts[0], Long.valueOf(parts[1]) + 1); }
diff --git a/src/main/java/net/onrc/onos/core/linkdiscovery/internal/LinkDiscoveryManager.java b/src/main/java/net/onrc/onos/core/linkdiscovery/internal/LinkDiscoveryManager.java index a395ab6..59abceb 100644 --- a/src/main/java/net/onrc/onos/core/linkdiscovery/internal/LinkDiscoveryManager.java +++ b/src/main/java/net/onrc/onos/core/linkdiscovery/internal/LinkDiscoveryManager.java
@@ -139,8 +139,8 @@ // periodically or in response to a recieved LLDP private static final byte TLV_DIRECTION_TYPE = 0x73; private static final short TLV_DIRECTION_LENGTH = 1; // 1 byte - private static final byte TLV_DIRECTION_VALUE_FORWARD[] = {0x01}; - private static final byte TLV_DIRECTION_VALUE_REVERSE[] = {0x02}; + private static final byte[] TLV_DIRECTION_VALUE_FORWARD = {0x01}; + private static final byte[] TLV_DIRECTION_VALUE_REVERSE = {0x02}; private static final LLDPTLV forwardTLV = new LLDPTLV(). setType(TLV_DIRECTION_TYPE).
diff --git a/src/main/java/net/onrc/onos/core/util/PerformanceMonitor.java b/src/main/java/net/onrc/onos/core/util/PerformanceMonitor.java index b6cdd94..fa05536 100644 --- a/src/main/java/net/onrc/onos/core/util/PerformanceMonitor.java +++ b/src/main/java/net/onrc/onos/core/util/PerformanceMonitor.java
@@ -256,7 +256,7 @@ theInstance.reportStep(tag); } - public static void main(String args[]) { + public static void main(String[] args) { // test the measurement overhead String tag; for (int i = 0; i < 2; i++) {