commit 424150c483484756d40ff46ebb817d0fc4f977c1
author Pavlin Radoslavov <pavlin@onlab.us> Wed Apr 09 12:12:36 2014 -0700
committer Gerrit Code Review <gerrit2@onos-services> Wed Apr 09 13:28:56 2014 -0700
tree d9576b6c1cef8f668ba81cebf7537f80580aa9d7
parent ec83894d0a5d9f83583e9246e8856daa455ddac2

Fix issues found by FindBugs: SBSC_USE_STRINGBUFFER_CONCATENATION

http://findbugs.sourceforge.net/bugDescriptions.html#SBSC_USE_STRINGBUFFER_CONCATENATION

Change-Id: I498d219e98cc821b4b9096697356cf54f7e033ce

src/main/java/net/onrc/onos/core/util/PerformanceMonitor.java

diff --git a/src/main/java/net/onrc/onos/core/util/PerformanceMonitor.java b/src/main/java/net/onrc/onos/core/util/PerformanceMonitor.java
index 7fb0597..5c02664 100644
--- a/src/main/java/net/onrc/onos/core/util/PerformanceMonitor.java
+++ b/src/main/java/net/onrc/onos/core/util/PerformanceMonitor.java
@@ -97,10 +97,12 @@
      * Write all performance measurements to the log
      */
     public void reportAll() {
-        String result = "Performance Results: (avg/start/stop/count)\n";
+        StringBuilder result = new StringBuilder();
+
+        result.append("Performance Results: (avg/start/stop/count)\n");
         if (map.size() == 0) {
-            result += "No Measurements";
-            log.error(result);
+            result.append("No Measurements");
+            log.error(result.toString());
             return;
         }
         long experimentEnd = -1;
@@ -131,16 +133,16 @@
             // Normalize start/stop
             start -= experimentStart;
             stop -= experimentStart;
-            result += key + '=' +
+            result.append(key + '=' +
                     (avg / NORMALIZATION) + '/' +
                     (start / NORMALIZATION) + '/' +
                     (stop / NORMALIZATION) + '/' +
-                    count + '\n';
+                    count + '\n');
         }
         double overheadMs = overhead / NORMALIZATION;
         double experimentElapsed = (experimentEnd - experimentStart) / NORMALIZATION;
-        result += "TotalTime:" + experimentElapsed + "/Overhead:" + overheadMs;
-        log.error(result);
+        result.append("TotalTime:" + experimentElapsed + "/Overhead:" + overheadMs);
+        log.error(result.toString());
 //      log.error("Performance Results: {} with measurement overhead: {} ms", map, overheadMilli);
     }