commit 35ef8e89ee0e096f237f63404a7a7a5ba64ce93d
author Pavlin Radoslavov <pavlin@onlab.us> Wed Apr 09 16:39:12 2014 -0700
committer Gerrit Code Review <gerrit2@onos-services> Wed Apr 09 22:31:51 2014 -0700
tree 9b40fb6c19ef0e8fb2dcc98b2cc007d55176cff7
parent 60c9b8fde4aea07f49f422223de85ead20e16df6

Fix issues found by FindBugs: EC_BAD_ARRAY_COMPARE

http://findbugs.sourceforge.net/bugDescriptions.html#EC_BAD_ARRAY_COMPARE

Change-Id: Ie5b10c9d8e7f9ab8d34c2556486bb5f35b059fa9

src/main/java/net/onrc/onos/core/packet/TCP.java

diff --git a/src/main/java/net/onrc/onos/core/packet/TCP.java b/src/main/java/net/onrc/onos/core/packet/TCP.java
index ec74f46..a81db21 100644
--- a/src/main/java/net/onrc/onos/core/packet/TCP.java
+++ b/src/main/java/net/onrc/onos/core/packet/TCP.java
@@ -18,6 +18,7 @@
 package net.onrc.onos.core.packet;
 
 import java.nio.ByteBuffer;
+import java.util.Arrays;
 
 /**
  * @author shudong.zhou@bigswitch.com
@@ -267,7 +268,7 @@
                 (flags == other.flags) &&
                 (windowSize == other.windowSize) &&
                 (urgentPointer == other.urgentPointer) &&
-                (dataOffset == 5 || options.equals(other.options));
+                (dataOffset == 5 || Arrays.equals(options, other.options));
     }
 
     @Override