Update findbugs versions.
- Update findbugs and maven plugins to 2.0.3 and 2.5.4.
- Fix for bugs detected by new version of findbugs
Note:
If you see "dependencies could not be resolved" error,
running "mvn clean verify -U" to force maven to check for new version in
remote repository might resolve the issue.
Change-Id: I26661aaf5d791980b0ab161649022e5bb7cf045d
diff --git a/src/main/java/net/onrc/onos/core/packet/IPv4.java b/src/main/java/net/onrc/onos/core/packet/IPv4.java
index f105428..1ce9eec 100644
--- a/src/main/java/net/onrc/onos/core/packet/IPv4.java
+++ b/src/main/java/net/onrc/onos/core/packet/IPv4.java
@@ -290,6 +290,7 @@
* -headerLength : 0
* -totalLength : 0
*/
+ @Override
public byte[] serialize() {
byte[] payloadData = null;
if (payload != null) {
@@ -410,7 +411,7 @@
int result = 0;
for (int i = 0; i < 4; ++i) {
- result |= Integer.valueOf(octets[i]) << ((3 - i) * 8);
+ result |= Integer.parseInt(octets[i]) << ((3 - i) * 8);
}
return result;
}
@@ -443,7 +444,7 @@
int result = 0;
for (int i = 0; i < 4; ++i) {
result = (ipAddress >> ((3 - i) * 8)) & 0xff;
- sb.append(Integer.valueOf(result).toString());
+ sb.append(Integer.toString(result));
if (i != 3) {
sb.append(".");
}