| commit | 0fe749a2143192f458adddca628c24f422771746 | [log] [tgz] |
|---|---|---|
| author | Yuta HIGUCHI <y-higuchi@onlab.us> | Tue May 27 09:35:16 2014 -0700 |
| committer | Gerrit Code Review <gerrit2@gerrit.onos.onlab.us> | Tue May 27 11:50:12 2014 -0700 |
| tree | 0d8f0ce870653a1424389f9221750c6a44c6326e | |
| parent | 9e53066a009c340917483a88ac5f676b66cf513c [diff] |
Update findbugs versions. - Update findbugs and maven plugins to 2.0.3 and 2.5.4. - Fix for bugs detected by new version of findbugs Note: If you see "dependencies could not be resolved" error, running "mvn clean verify -U" to force maven to check for new version in remote repository might resolve the issue. Change-Id: I26661aaf5d791980b0ab161649022e5bb7cf045d
diff --git a/src/main/java/net/onrc/onos/core/flowprogrammer/FlowPusher.java b/src/main/java/net/onrc/onos/core/flowprogrammer/FlowPusher.java index cba6ee1..661f5c0 100644 --- a/src/main/java/net/onrc/onos/core/flowprogrammer/FlowPusher.java +++ b/src/main/java/net/onrc/onos/core/flowprogrammer/FlowPusher.java
@@ -341,7 +341,7 @@ for (IOFSwitch sw : keys) { SwitchQueue queue = assignedQueues.get(sw); - if (sw == null || queue == null) { + if (queue == null) { continue; }
diff --git a/src/main/java/net/onrc/onos/core/flowprogrammer/web/SetPushRateResource.java b/src/main/java/net/onrc/onos/core/flowprogrammer/web/SetPushRateResource.java index 11bbd28..a2993a5 100644 --- a/src/main/java/net/onrc/onos/core/flowprogrammer/web/SetPushRateResource.java +++ b/src/main/java/net/onrc/onos/core/flowprogrammer/web/SetPushRateResource.java
@@ -28,7 +28,7 @@ try { dpid = HexString.toLong((String) getRequestAttributes().get("dpid")); - rate = Long.valueOf((String) getRequestAttributes().get("rate")); + rate = Long.parseLong((String) getRequestAttributes().get("rate")); } catch (NumberFormatException e) { log.error("Invalid number format"); return false;