commit 0b122edad2f7dbf09817708ee9c4cf2e1cfa6fa8
author Ray Milkey <ray@onlab.us> Mon Apr 14 10:06:03 2014 -0700
committer Ray Milkey <ray@onlab.us> Tue Apr 15 11:05:35 2014 -0700
tree 447f9ab7aa034da14531089bef7846ba31d2aede
parent 6920035098121185afeb30f63e6d6fa2379e76a6

Enable checkstyle rule for missing defaults in switch statements

Enabled the checkstyle rule that looks for switch statements that
don't have a default label and fixed the violations that were
found.

Code review results for switch statement default branches

Change-Id: I68716894952835def659b4fcab5b381aaf9ff89e

src/main/java/net/onrc/onos/core/packet/DHCPPacketType.java

diff --git a/src/main/java/net/onrc/onos/core/packet/DHCPPacketType.java b/src/main/java/net/onrc/onos/core/packet/DHCPPacketType.java
index 7c4cdb8..eb43d34 100644
--- a/src/main/java/net/onrc/onos/core/packet/DHCPPacketType.java
+++ b/src/main/java/net/onrc/onos/core/packet/DHCPPacketType.java
@@ -77,9 +77,9 @@
                 return "DHCPLEASEUNKNOWN";
             case 13:
                 return "DHCPLEASEACTIVE";
+            default:
+                return "DHCP_UnknownType(" + value + ")";
         }
-
-        return "DHCP_UnknownType(" + value + ")";
     }
 
     public static DHCPPacketType getType(int value) {
@@ -110,8 +110,8 @@
                 return DHCPLEASEUNKNOWN;
             case 13:
                 return DHCPLEASEACTIVE;
+            default:
+                return null;
         }
-
-        return null;
     }
 }