commit | 0002b2de14cb6e53d36cf81195b6d4af4f016137 | [log] [tgz] |
---|---|---|
author | Pavlin Radoslavov <pavlin@onlab.us> | Thu Apr 10 14:57:37 2014 -0700 |
committer | Pavlin Radoslavov <pavlin@onlab.us> | Thu Apr 10 14:57:37 2014 -0700 |
tree | 2d9a449d20c5d127be72088f39ace2ac5e61e432 | |
parent | df826c931dd5483f21e8e451b845210271d406fc [diff] |
Fix issues found by FindBugs: ICAST_INTEGER_MULTIPLY_CAST_TO_LONG http://findbugs.sourceforge.net/bugDescriptions.html#ICAST_INTEGER_MULTIPLY_CAST_TO_LONG For some reason, initially FindBugs reported only a single ICAST_INTEGER_MULTIPLY_CAST_TO_LONG issue within this file (fixed earlier). After this issue was fixed, FindBugs reported another issue (fixed in this patch). Change-Id: I9321a9d89967afcd2e0548560dfc6acc60530ee7
diff --git a/src/main/java/net/onrc/onos/core/linkdiscovery/internal/LinkDiscoveryManager.java b/src/main/java/net/onrc/onos/core/linkdiscovery/internal/LinkDiscoveryManager.java index adcacd8..7989aaa 100644 --- a/src/main/java/net/onrc/onos/core/linkdiscovery/internal/LinkDiscoveryManager.java +++ b/src/main/java/net/onrc/onos/core/linkdiscovery/internal/LinkDiscoveryManager.java
@@ -1523,7 +1523,7 @@ linkChanged = true; } if ((info.getMulticastValidTime() != null) && - (info.getMulticastValidTime() + (this.LINK_TIMEOUT * 1000) < curTime)) { + (info.getMulticastValidTime() + (1000L * this.LINK_TIMEOUT) < curTime)) { info.setMulticastValidTime(null); // if uTime is not null, then link will remain as openflow // link. If uTime is null, it will be deleted. So, we