Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2017-present Open Networking Foundation |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | package org.onosproject.drivers.p4runtime; |
| 18 | |
Wailok Shum | 6d42cff | 2021-08-22 19:40:13 +0800 | [diff] [blame] | 19 | import com.google.common.collect.Lists; |
Wailok Shum | f013a78 | 2021-07-26 16:51:01 +0800 | [diff] [blame] | 20 | import com.google.common.collect.Sets; |
Wailok Shum | 6d42cff | 2021-08-22 19:40:13 +0800 | [diff] [blame] | 21 | import com.google.common.util.concurrent.Striped; |
Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 22 | import org.onosproject.drivers.p4runtime.mirror.P4RuntimeMeterMirror; |
Wailok Shum | 6d42cff | 2021-08-22 19:40:13 +0800 | [diff] [blame] | 23 | import org.onosproject.drivers.p4runtime.mirror.TimedEntry; |
Wailok Shum | f013a78 | 2021-07-26 16:51:01 +0800 | [diff] [blame] | 24 | import org.onosproject.net.DeviceId; |
Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 25 | import org.onosproject.net.meter.Band; |
Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 26 | import org.onosproject.net.meter.DefaultMeter; |
Wailok Shum | f013a78 | 2021-07-26 16:51:01 +0800 | [diff] [blame] | 27 | import org.onosproject.net.meter.DefaultMeterFeatures; |
Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 28 | import org.onosproject.net.meter.Meter; |
Wailok Shum | f013a78 | 2021-07-26 16:51:01 +0800 | [diff] [blame] | 29 | import org.onosproject.net.meter.MeterFeatures; |
Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 30 | import org.onosproject.net.meter.MeterOperation; |
| 31 | import org.onosproject.net.meter.MeterProgrammable; |
Wailok Shum | f013a78 | 2021-07-26 16:51:01 +0800 | [diff] [blame] | 32 | import org.onosproject.net.meter.MeterScope; |
Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 33 | import org.onosproject.net.meter.MeterState; |
| 34 | import org.onosproject.net.pi.model.PiMeterId; |
| 35 | import org.onosproject.net.pi.model.PiMeterModel; |
| 36 | import org.onosproject.net.pi.model.PiPipelineModel; |
| 37 | import org.onosproject.net.pi.runtime.PiMeterCellConfig; |
Carmelo Cascone | 4c289b7 | 2019-01-22 15:30:45 -0800 | [diff] [blame] | 38 | import org.onosproject.net.pi.runtime.PiMeterCellHandle; |
Wailok Shum | 9664209 | 2021-08-06 16:23:36 +0800 | [diff] [blame] | 39 | import org.onosproject.net.pi.runtime.PiMeterCellId; |
Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 40 | import org.onosproject.net.pi.service.PiMeterTranslator; |
Wailok Shum | 6d42cff | 2021-08-22 19:40:13 +0800 | [diff] [blame] | 41 | import org.onosproject.net.pi.service.PiTranslatedEntity; |
Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 42 | import org.onosproject.net.pi.service.PiTranslationException; |
Wailok Shum | 6d42cff | 2021-08-22 19:40:13 +0800 | [diff] [blame] | 43 | import org.onosproject.p4runtime.api.P4RuntimeWriteClient.WriteRequest; |
Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 44 | |
| 45 | import java.util.Collection; |
| 46 | import java.util.Collections; |
Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 47 | import java.util.HashSet; |
Wailok Shum | 6d42cff | 2021-08-22 19:40:13 +0800 | [diff] [blame] | 48 | import java.util.List; |
| 49 | import java.util.Optional; |
Carmelo Cascone | e5b2872 | 2018-06-22 17:28:28 +0200 | [diff] [blame] | 50 | import java.util.Set; |
Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 51 | import java.util.concurrent.CompletableFuture; |
Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 52 | import java.util.concurrent.locks.Lock; |
Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 53 | |
Wailok Shum | f013a78 | 2021-07-26 16:51:01 +0800 | [diff] [blame] | 54 | import static com.google.common.base.Preconditions.checkNotNull; |
Wailok Shum | 6d42cff | 2021-08-22 19:40:13 +0800 | [diff] [blame] | 55 | import static org.onosproject.p4runtime.api.P4RuntimeWriteClient.UpdateType; |
Wailok Shum | f013a78 | 2021-07-26 16:51:01 +0800 | [diff] [blame] | 56 | |
Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 57 | /** |
| 58 | * Implementation of MeterProgrammable behaviour for P4Runtime. |
| 59 | */ |
| 60 | public class P4RuntimeMeterProgrammable extends AbstractP4RuntimeHandlerBehaviour implements MeterProgrammable { |
| 61 | |
Wailok Shum | 6d42cff | 2021-08-22 19:40:13 +0800 | [diff] [blame] | 62 | private static final Striped<Lock> WRITE_LOCKS = Striped.lock(30); |
Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 63 | |
| 64 | private PiMeterTranslator translator; |
| 65 | private P4RuntimeMeterMirror meterMirror; |
| 66 | private PiPipelineModel pipelineModel; |
| 67 | |
| 68 | @Override |
Carmelo Cascone | c32976e | 2019-04-08 14:50:52 -0700 | [diff] [blame] | 69 | protected boolean setupBehaviour(String opName) { |
| 70 | if (!super.setupBehaviour(opName)) { |
Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 71 | return false; |
| 72 | } |
| 73 | |
Yi Tseng | d771648 | 2018-10-31 15:34:30 -0700 | [diff] [blame] | 74 | translator = translationService.meterTranslator(); |
Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 75 | meterMirror = handler().get(P4RuntimeMeterMirror.class); |
| 76 | pipelineModel = pipeconf.pipelineModel(); |
| 77 | return true; |
| 78 | } |
| 79 | |
| 80 | @Override |
| 81 | public CompletableFuture<Boolean> performMeterOperation(MeterOperation meterOp) { |
| 82 | |
Carmelo Cascone | c32976e | 2019-04-08 14:50:52 -0700 | [diff] [blame] | 83 | if (!setupBehaviour("performMeterOperation()")) { |
Kevin Chuang | c267df2 | 2018-05-02 16:26:04 +0800 | [diff] [blame] | 84 | return CompletableFuture.completedFuture(false); |
| 85 | } |
| 86 | |
Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 87 | return CompletableFuture.completedFuture(processMeterOp(meterOp)); |
| 88 | } |
| 89 | |
| 90 | private boolean processMeterOp(MeterOperation meterOp) { |
Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 91 | PiMeterCellConfig piMeterCellConfig; |
Wailok Shum | 6d42cff | 2021-08-22 19:40:13 +0800 | [diff] [blame] | 92 | final PiMeterCellHandle handle = PiMeterCellHandle.of(deviceId, |
| 93 | (PiMeterCellId) meterOp.meter().meterCellId()); |
| 94 | boolean result = true; |
| 95 | WRITE_LOCKS.get(deviceId).lock(); |
| 96 | try { |
| 97 | switch (meterOp.type()) { |
| 98 | case ADD: |
| 99 | case MODIFY: |
| 100 | // Create a config for modify operation |
| 101 | try { |
| 102 | piMeterCellConfig = translator.translate(meterOp.meter(), pipeconf); |
| 103 | } catch (PiTranslationException e) { |
| 104 | log.warn("Unable translate meter, aborting meter operation {}: {}", |
| 105 | meterOp.type(), e.getMessage()); |
| 106 | log.debug("exception", e); |
| 107 | return false; |
| 108 | } |
| 109 | translator.learn(handle, new PiTranslatedEntity<>(meterOp.meter(), piMeterCellConfig, handle)); |
| 110 | break; |
| 111 | case REMOVE: |
| 112 | // Create a empty config for reset operation |
| 113 | PiMeterCellId piMeterCellId = (PiMeterCellId) meterOp.meter().meterCellId(); |
| 114 | piMeterCellConfig = PiMeterCellConfig.reset(piMeterCellId); |
| 115 | translator.forget(handle); |
| 116 | break; |
| 117 | default: |
| 118 | log.warn("Meter Operation type {} not supported", meterOp.type()); |
Wailok Shum | 9664209 | 2021-08-06 16:23:36 +0800 | [diff] [blame] | 119 | return false; |
Wailok Shum | 6d42cff | 2021-08-22 19:40:13 +0800 | [diff] [blame] | 120 | } |
| 121 | |
| 122 | WriteRequest request = client.write(p4DeviceId, pipeconf); |
| 123 | appendEntryToWriteRequestOrSkip(request, handle, piMeterCellConfig); |
| 124 | if (!request.pendingUpdates().isEmpty()) { |
| 125 | result = request.submitSync().isSuccess(); |
| 126 | if (result) { |
| 127 | meterMirror.applyWriteRequest(request); |
Wailok Shum | 9664209 | 2021-08-06 16:23:36 +0800 | [diff] [blame] | 128 | } |
Wailok Shum | 6d42cff | 2021-08-22 19:40:13 +0800 | [diff] [blame] | 129 | } |
| 130 | } finally { |
| 131 | WRITE_LOCKS.get(deviceId).unlock(); |
Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 132 | } |
Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 133 | return result; |
| 134 | } |
| 135 | |
| 136 | @Override |
| 137 | public CompletableFuture<Collection<Meter>> getMeters() { |
| 138 | |
Carmelo Cascone | c32976e | 2019-04-08 14:50:52 -0700 | [diff] [blame] | 139 | if (!setupBehaviour("getMeters()")) { |
Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 140 | return CompletableFuture.completedFuture(Collections.emptyList()); |
| 141 | } |
| 142 | |
| 143 | Collection<PiMeterCellConfig> piMeterCellConfigs; |
| 144 | |
| 145 | Set<PiMeterId> meterIds = new HashSet<>(); |
| 146 | for (PiMeterModel mode : pipelineModel.meters()) { |
| 147 | meterIds.add(mode.id()); |
| 148 | } |
| 149 | |
Carmelo Cascone | c2be50a | 2019-04-10 00:15:39 -0700 | [diff] [blame] | 150 | piMeterCellConfigs = client.read(p4DeviceId, pipeconf) |
Carmelo Cascone | 4c289b7 | 2019-01-22 15:30:45 -0800 | [diff] [blame] | 151 | .meterCells(meterIds).submitSync().all(PiMeterCellConfig.class); |
Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 152 | |
Wailok Shum | 6d42cff | 2021-08-22 19:40:13 +0800 | [diff] [blame] | 153 | meterMirror.sync(deviceId, piMeterCellConfigs); |
| 154 | |
| 155 | if (piMeterCellConfigs.isEmpty()) { |
| 156 | return CompletableFuture.completedFuture(Collections.emptyList()); |
| 157 | } |
| 158 | |
| 159 | List<PiMeterCellId> inconsistentOrDefaultCells = Lists.newArrayList(); |
| 160 | List<Meter> meters = Lists.newArrayList(); |
| 161 | |
| 162 | // Check the consistency of meter config |
| 163 | for (PiMeterCellConfig config : piMeterCellConfigs) { |
| 164 | PiMeterCellHandle handle = PiMeterCellHandle.of(deviceId, config); |
| 165 | DefaultMeter meter = (DefaultMeter) forgeMeter(config, handle); |
| 166 | if (meter == null) { |
| 167 | // A default config cannot be used to forge meter |
| 168 | // because meter has at least 1 band while default config has no band |
| 169 | inconsistentOrDefaultCells.add(config.cellId()); |
| 170 | } else { |
| 171 | meters.add(meter); |
| 172 | } |
| 173 | } |
| 174 | |
pierventre | c0914ec | 2021-08-27 15:25:02 +0200 | [diff] [blame^] | 175 | // Reset all inconsistent meter cells to the default config |
Wailok Shum | 6d42cff | 2021-08-22 19:40:13 +0800 | [diff] [blame] | 176 | if (!inconsistentOrDefaultCells.isEmpty()) { |
| 177 | WriteRequest request = client.write(p4DeviceId, pipeconf); |
| 178 | for (PiMeterCellId cellId : inconsistentOrDefaultCells) { |
| 179 | PiMeterCellHandle handle = PiMeterCellHandle.of(deviceId, cellId); |
| 180 | appendEntryToWriteRequestOrSkip(request, handle, PiMeterCellConfig.reset(cellId)); |
| 181 | } |
pierventre | c0914ec | 2021-08-27 15:25:02 +0200 | [diff] [blame^] | 182 | |
| 183 | request.submit().whenComplete((response, ex) -> { |
| 184 | if (ex != null) { |
| 185 | log.error("Exception resetting inconsistent meter entries", ex); |
| 186 | } else { |
| 187 | log.debug("Successfully removed {} out of {} inconsistent meter entries", |
| 188 | response.success().size(), response.all().size()); |
| 189 | } |
| 190 | response.success().forEach(entity -> meterMirror.remove((PiMeterCellHandle) entity.handle())); |
| 191 | }); |
Wailok Shum | 6d42cff | 2021-08-22 19:40:13 +0800 | [diff] [blame] | 192 | } |
Frank Wang | d7e3b4b | 2017-09-24 13:37:54 +0900 | [diff] [blame] | 193 | |
| 194 | return CompletableFuture.completedFuture(meters); |
| 195 | } |
Wailok Shum | f013a78 | 2021-07-26 16:51:01 +0800 | [diff] [blame] | 196 | |
| 197 | @Override |
| 198 | public CompletableFuture<Collection<MeterFeatures>> getMeterFeatures() { |
| 199 | |
| 200 | if (!setupBehaviour("getMeterFeatures()")) { |
| 201 | return CompletableFuture.completedFuture(Collections.emptyList()); |
| 202 | } |
| 203 | |
| 204 | Collection<MeterFeatures> meterFeatures = new HashSet<>(); |
| 205 | pipeconf.pipelineModel().meters().forEach( |
| 206 | m -> meterFeatures.add(new P4RuntimeMeterFeaturesBuilder(m, deviceId).build())); |
| 207 | |
| 208 | return CompletableFuture.completedFuture(meterFeatures); |
| 209 | } |
| 210 | |
Wailok Shum | 6d42cff | 2021-08-22 19:40:13 +0800 | [diff] [blame] | 211 | private Meter forgeMeter(PiMeterCellConfig config, PiMeterCellHandle handle) { |
| 212 | final Optional<PiTranslatedEntity<Meter, PiMeterCellConfig>> |
| 213 | translatedEntity = translator.lookup(handle); |
| 214 | final TimedEntry<PiMeterCellConfig> timedEntry = meterMirror.get(handle); |
| 215 | |
| 216 | // A meter cell config might not be present in the translation store if it |
| 217 | // is default configuration. |
| 218 | if (translatedEntity.isEmpty()) { |
| 219 | if (!config.isDefaultConfig()) { |
| 220 | log.warn("Meter Cell Config obtained from device {} is different from " + |
| 221 | "one in in translation store: device={}, store=Default", deviceId, config); |
| 222 | } else { |
| 223 | log.debug("Configs obtained from device: {} and present in the store are default, " + |
pierventre | c0914ec | 2021-08-27 15:25:02 +0200 | [diff] [blame^] | 224 | "skipping the forge section", deviceId); |
Wailok Shum | 6d42cff | 2021-08-22 19:40:13 +0800 | [diff] [blame] | 225 | } |
| 226 | return null; |
| 227 | } |
pierventre | c0914ec | 2021-08-27 15:25:02 +0200 | [diff] [blame^] | 228 | |
Wailok Shum | 6d42cff | 2021-08-22 19:40:13 +0800 | [diff] [blame] | 229 | // The config is not consistent |
| 230 | if (!translatedEntity.get().translated().equals(config)) { |
| 231 | log.warn("Meter Cell Config obtained from device {} is different from " + |
| 232 | "one in in translation store: device={}, store={}", |
| 233 | deviceId, config, translatedEntity.get().translated()); |
| 234 | return null; |
| 235 | } |
pierventre | c0914ec | 2021-08-27 15:25:02 +0200 | [diff] [blame^] | 236 | |
| 237 | // Big problems in the mirror ? This could happen in case of issues with |
| 238 | // the eventual consistent maps used in the AbstractDistributedP4RuntimeMirror |
Wailok Shum | 6d42cff | 2021-08-22 19:40:13 +0800 | [diff] [blame] | 239 | if (timedEntry == null) { |
| 240 | log.warn("Meter entry handle not found in device mirror: {}", handle); |
| 241 | return null; |
| 242 | } |
| 243 | |
pierventre | c0914ec | 2021-08-27 15:25:02 +0200 | [diff] [blame^] | 244 | Meter original = translatedEntity.get().original(); |
| 245 | // Forge a meter with MeterCellId, Bands and DeviceId using the original value. |
Wailok Shum | 6d42cff | 2021-08-22 19:40:13 +0800 | [diff] [blame] | 246 | // Other values are not required because we cannot retrieve them from the south |
| 247 | DefaultMeter meter = (DefaultMeter) DefaultMeter.builder() |
pierventre | c0914ec | 2021-08-27 15:25:02 +0200 | [diff] [blame^] | 248 | .withBands(original.bands()) |
| 249 | .withCellId(original.meterCellId()) |
Wailok Shum | 6d42cff | 2021-08-22 19:40:13 +0800 | [diff] [blame] | 250 | .forDevice(deviceId) |
| 251 | .build(); |
| 252 | meter.setState(MeterState.ADDED); |
| 253 | return meter; |
| 254 | } |
| 255 | |
| 256 | private boolean appendEntryToWriteRequestOrSkip( |
| 257 | final WriteRequest writeRequest, |
| 258 | final PiMeterCellHandle handle, |
| 259 | PiMeterCellConfig configToModify) { |
| 260 | |
| 261 | final TimedEntry<PiMeterCellConfig> configOnDevice = meterMirror.get(handle); |
| 262 | |
| 263 | if (configOnDevice != null && configOnDevice.entry().equals(configToModify)) { |
| 264 | log.debug("Ignoring re-apply of existing entry: {}", configToModify); |
| 265 | return true; |
| 266 | } |
| 267 | |
| 268 | writeRequest.entity(configToModify, UpdateType.MODIFY); |
| 269 | |
| 270 | return false; |
| 271 | } |
| 272 | |
Wailok Shum | f013a78 | 2021-07-26 16:51:01 +0800 | [diff] [blame] | 273 | /** |
| 274 | * P4 meter features builder. |
| 275 | */ |
pierventre | c0914ec | 2021-08-27 15:25:02 +0200 | [diff] [blame^] | 276 | public static class P4RuntimeMeterFeaturesBuilder { |
Wailok Shum | f013a78 | 2021-07-26 16:51:01 +0800 | [diff] [blame] | 277 | private final PiMeterModel piMeterModel; |
| 278 | private DeviceId deviceId; |
| 279 | |
| 280 | private static final long PI_METER_START_INDEX = 0L; |
| 281 | private static final short PI_METER_MAX_BAND = 2; |
| 282 | private static final short PI_METER_MAX_COLOR = 3; |
| 283 | |
| 284 | public P4RuntimeMeterFeaturesBuilder(PiMeterModel piMeterModel, DeviceId deviceId) { |
| 285 | this.piMeterModel = checkNotNull(piMeterModel); |
| 286 | this.deviceId = deviceId; |
| 287 | } |
| 288 | |
| 289 | /** |
| 290 | * To build a MeterFeatures using the PiMeterModel object |
| 291 | * retrieved from pipeconf. |
| 292 | * |
| 293 | * @return the meter features object |
| 294 | */ |
| 295 | public MeterFeatures build() { |
pierventre | c0914ec | 2021-08-27 15:25:02 +0200 | [diff] [blame^] | 296 | // We set the basic values before to extract the other information. |
Wailok Shum | f013a78 | 2021-07-26 16:51:01 +0800 | [diff] [blame] | 297 | MeterFeatures.Builder builder = DefaultMeterFeatures.builder() |
| 298 | .forDevice(deviceId) |
| 299 | // The scope value will be PiMeterId |
| 300 | .withScope(MeterScope.of(piMeterModel.id().id())) |
| 301 | .withMaxBands(PI_METER_MAX_BAND) |
| 302 | .withMaxColors(PI_METER_MAX_COLOR) |
| 303 | .withStartIndex(PI_METER_START_INDEX) |
| 304 | .withEndIndex(piMeterModel.size() - 1); |
pierventre | c0914ec | 2021-08-27 15:25:02 +0200 | [diff] [blame^] | 305 | |
| 306 | // p4rt meters support MARK_YELLOW (committed config) and |
| 307 | // MARK_RED (peak config) band types. |
Wailok Shum | f013a78 | 2021-07-26 16:51:01 +0800 | [diff] [blame] | 308 | Set<Band.Type> bands = Sets.newHashSet(); |
pierventre | c0914ec | 2021-08-27 15:25:02 +0200 | [diff] [blame^] | 309 | bands.add(Band.Type.MARK_YELLOW); |
| 310 | bands.add(Band.Type.MARK_RED); |
Wailok Shum | f013a78 | 2021-07-26 16:51:01 +0800 | [diff] [blame] | 311 | builder.withBandTypes(bands); |
pierventre | c0914ec | 2021-08-27 15:25:02 +0200 | [diff] [blame^] | 312 | |
| 313 | // We extract the supported units; |
Wailok Shum | f013a78 | 2021-07-26 16:51:01 +0800 | [diff] [blame] | 314 | Set<Meter.Unit> units = Sets.newHashSet(); |
| 315 | if (piMeterModel.unit() == PiMeterModel.Unit.BYTES) { |
pierventre | c0914ec | 2021-08-27 15:25:02 +0200 | [diff] [blame^] | 316 | units.add(Meter.Unit.BYTES_PER_SEC); |
Wailok Shum | f013a78 | 2021-07-26 16:51:01 +0800 | [diff] [blame] | 317 | } else if (piMeterModel.unit() == PiMeterModel.Unit.PACKETS) { |
| 318 | units.add(Meter.Unit.PKTS_PER_SEC); |
| 319 | } |
Wailok Shum | f013a78 | 2021-07-26 16:51:01 +0800 | [diff] [blame] | 320 | |
pierventre | c0914ec | 2021-08-27 15:25:02 +0200 | [diff] [blame^] | 321 | return builder.withUnits(units) |
| 322 | .hasBurst(true) |
| 323 | .hasStats(false) |
| 324 | .build(); |
Wailok Shum | f013a78 | 2021-07-26 16:51:01 +0800 | [diff] [blame] | 325 | } |
| 326 | |
| 327 | /** |
| 328 | * To build an empty meter features. |
pierventre | c0914ec | 2021-08-27 15:25:02 +0200 | [diff] [blame^] | 329 | * |
Wailok Shum | f013a78 | 2021-07-26 16:51:01 +0800 | [diff] [blame] | 330 | * @param deviceId the device id |
| 331 | * @return the meter features |
| 332 | */ |
| 333 | public MeterFeatures noMeterFeatures(DeviceId deviceId) { |
| 334 | return DefaultMeterFeatures.noMeterFeatures(deviceId); |
| 335 | } |
| 336 | } |
Carmelo Cascone | e5b2872 | 2018-06-22 17:28:28 +0200 | [diff] [blame] | 337 | } |