alshabib | e27055b | 2015-07-09 21:43:10 -0700 | [diff] [blame] | 1 | /* |
Brian O'Connor | 5ab426f | 2016-04-09 01:19:45 -0700 | [diff] [blame] | 2 | * Copyright 2015-present Open Networking Laboratory |
alshabib | e27055b | 2015-07-09 21:43:10 -0700 | [diff] [blame] | 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | package org.onosproject.provider.of.meter.impl; |
| 18 | |
alshabib | 1d2bc40 | 2015-07-31 17:04:11 -0700 | [diff] [blame] | 19 | |
alshabib | c791179 | 2015-07-30 17:55:30 -0700 | [diff] [blame] | 20 | import com.google.common.cache.Cache; |
| 21 | import com.google.common.cache.CacheBuilder; |
| 22 | import com.google.common.cache.RemovalCause; |
| 23 | import com.google.common.cache.RemovalNotification; |
| 24 | import com.google.common.collect.Maps; |
| 25 | import org.apache.felix.scr.annotations.Activate; |
alshabib | e27055b | 2015-07-09 21:43:10 -0700 | [diff] [blame] | 26 | import org.apache.felix.scr.annotations.Component; |
alshabib | c791179 | 2015-07-30 17:55:30 -0700 | [diff] [blame] | 27 | import org.apache.felix.scr.annotations.Deactivate; |
alshabib | e27055b | 2015-07-09 21:43:10 -0700 | [diff] [blame] | 28 | import org.apache.felix.scr.annotations.Reference; |
| 29 | import org.apache.felix.scr.annotations.ReferenceCardinality; |
alshabib | 7bb0501 | 2015-08-05 10:15:09 -0700 | [diff] [blame] | 30 | import org.onosproject.core.CoreService; |
alshabib | 10c810b | 2015-08-18 16:59:04 -0700 | [diff] [blame] | 31 | import org.onosproject.net.meter.Band; |
| 32 | import org.onosproject.net.meter.DefaultBand; |
| 33 | import org.onosproject.net.meter.DefaultMeter; |
| 34 | import org.onosproject.net.meter.Meter; |
| 35 | import org.onosproject.net.meter.MeterFailReason; |
alshabib | 58fe6dc | 2015-08-19 17:16:13 -0700 | [diff] [blame] | 36 | import org.onosproject.net.meter.MeterId; |
alshabib | 10c810b | 2015-08-18 16:59:04 -0700 | [diff] [blame] | 37 | import org.onosproject.net.meter.MeterOperation; |
| 38 | import org.onosproject.net.meter.MeterOperations; |
| 39 | import org.onosproject.net.meter.MeterProvider; |
| 40 | import org.onosproject.net.meter.MeterProviderRegistry; |
| 41 | import org.onosproject.net.meter.MeterProviderService; |
| 42 | import org.onosproject.net.meter.MeterState; |
alshabib | 7bb0501 | 2015-08-05 10:15:09 -0700 | [diff] [blame] | 43 | import org.onosproject.net.DeviceId; |
alshabib | e27055b | 2015-07-09 21:43:10 -0700 | [diff] [blame] | 44 | import org.onosproject.net.provider.AbstractProvider; |
| 45 | import org.onosproject.net.provider.ProviderId; |
alshabib | c791179 | 2015-07-30 17:55:30 -0700 | [diff] [blame] | 46 | import org.onosproject.openflow.controller.Dpid; |
alshabib | e27055b | 2015-07-09 21:43:10 -0700 | [diff] [blame] | 47 | import org.onosproject.openflow.controller.OpenFlowController; |
alshabib | c791179 | 2015-07-30 17:55:30 -0700 | [diff] [blame] | 48 | import org.onosproject.openflow.controller.OpenFlowEventListener; |
| 49 | import org.onosproject.openflow.controller.OpenFlowSwitch; |
| 50 | import org.onosproject.openflow.controller.OpenFlowSwitchListener; |
| 51 | import org.onosproject.openflow.controller.RoleState; |
| 52 | import org.projectfloodlight.openflow.protocol.OFErrorMsg; |
| 53 | import org.projectfloodlight.openflow.protocol.OFErrorType; |
| 54 | import org.projectfloodlight.openflow.protocol.OFMessage; |
alshabib | 7bb0501 | 2015-08-05 10:15:09 -0700 | [diff] [blame] | 55 | import org.projectfloodlight.openflow.protocol.OFMeterBandStats; |
| 56 | import org.projectfloodlight.openflow.protocol.OFMeterConfigStatsReply; |
| 57 | import org.projectfloodlight.openflow.protocol.OFMeterStats; |
| 58 | import org.projectfloodlight.openflow.protocol.OFMeterStatsReply; |
alshabib | c791179 | 2015-07-30 17:55:30 -0700 | [diff] [blame] | 59 | import org.projectfloodlight.openflow.protocol.OFPortStatus; |
| 60 | import org.projectfloodlight.openflow.protocol.OFStatsReply; |
alshabib | 7bb0501 | 2015-08-05 10:15:09 -0700 | [diff] [blame] | 61 | import org.projectfloodlight.openflow.protocol.OFStatsType; |
alshabib | c791179 | 2015-07-30 17:55:30 -0700 | [diff] [blame] | 62 | import org.projectfloodlight.openflow.protocol.OFVersion; |
| 63 | import org.projectfloodlight.openflow.protocol.errormsg.OFMeterModFailedErrorMsg; |
alshabib | e27055b | 2015-07-09 21:43:10 -0700 | [diff] [blame] | 64 | import org.slf4j.Logger; |
| 65 | |
alshabib | 7bb0501 | 2015-08-05 10:15:09 -0700 | [diff] [blame] | 66 | import java.util.Collection; |
| 67 | import java.util.List; |
alshabib | c791179 | 2015-07-30 17:55:30 -0700 | [diff] [blame] | 68 | import java.util.Map; |
| 69 | import java.util.concurrent.TimeUnit; |
| 70 | import java.util.concurrent.atomic.AtomicLong; |
alshabib | 7bb0501 | 2015-08-05 10:15:09 -0700 | [diff] [blame] | 71 | import java.util.stream.Collectors; |
alshabib | c791179 | 2015-07-30 17:55:30 -0700 | [diff] [blame] | 72 | |
alshabib | e27055b | 2015-07-09 21:43:10 -0700 | [diff] [blame] | 73 | import static org.slf4j.LoggerFactory.getLogger; |
| 74 | |
| 75 | /** |
| 76 | * Provider which uses an OpenFlow controller to handle meters. |
| 77 | */ |
alshabib | 58fe6dc | 2015-08-19 17:16:13 -0700 | [diff] [blame] | 78 | @Component(immediate = true, enabled = true) |
alshabib | e27055b | 2015-07-09 21:43:10 -0700 | [diff] [blame] | 79 | public class OpenFlowMeterProvider extends AbstractProvider implements MeterProvider { |
| 80 | |
alshabib | c791179 | 2015-07-30 17:55:30 -0700 | [diff] [blame] | 81 | |
alshabib | e27055b | 2015-07-09 21:43:10 -0700 | [diff] [blame] | 82 | private final Logger log = getLogger(getClass()); |
| 83 | |
| 84 | @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY) |
| 85 | protected OpenFlowController controller; |
| 86 | |
alshabib | c791179 | 2015-07-30 17:55:30 -0700 | [diff] [blame] | 87 | @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY) |
| 88 | protected MeterProviderRegistry providerRegistry; |
| 89 | |
alshabib | 7bb0501 | 2015-08-05 10:15:09 -0700 | [diff] [blame] | 90 | @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY) |
| 91 | protected CoreService coreService; |
| 92 | |
alshabib | c791179 | 2015-07-30 17:55:30 -0700 | [diff] [blame] | 93 | private MeterProviderService providerService; |
| 94 | |
| 95 | private static final AtomicLong XID_COUNTER = new AtomicLong(1); |
| 96 | |
| 97 | static final int POLL_INTERVAL = 10; |
| 98 | static final long TIMEOUT = 30; |
| 99 | |
alshabib | 7bb0501 | 2015-08-05 10:15:09 -0700 | [diff] [blame] | 100 | private Cache<Long, MeterOperation> pendingOperations; |
alshabib | c791179 | 2015-07-30 17:55:30 -0700 | [diff] [blame] | 101 | |
| 102 | |
| 103 | private InternalMeterListener listener = new InternalMeterListener(); |
| 104 | private Map<Dpid, MeterStatsCollector> collectors = Maps.newHashMap(); |
alshabib | e27055b | 2015-07-09 21:43:10 -0700 | [diff] [blame] | 105 | |
| 106 | /** |
| 107 | * Creates a OpenFlow meter provider. |
| 108 | */ |
| 109 | public OpenFlowMeterProvider() { |
| 110 | super(new ProviderId("of", "org.onosproject.provider.meter")); |
| 111 | } |
alshabib | bc37196 | 2015-07-09 22:26:21 -0700 | [diff] [blame] | 112 | |
alshabib | c791179 | 2015-07-30 17:55:30 -0700 | [diff] [blame] | 113 | @Activate |
| 114 | public void activate() { |
| 115 | providerService = providerRegistry.register(this); |
| 116 | |
| 117 | pendingOperations = CacheBuilder.newBuilder() |
| 118 | .expireAfterWrite(TIMEOUT, TimeUnit.SECONDS) |
alshabib | 7bb0501 | 2015-08-05 10:15:09 -0700 | [diff] [blame] | 119 | .removalListener((RemovalNotification<Long, MeterOperation> notification) -> { |
alshabib | c791179 | 2015-07-30 17:55:30 -0700 | [diff] [blame] | 120 | if (notification.getCause() == RemovalCause.EXPIRED) { |
| 121 | providerService.meterOperationFailed(notification.getValue(), |
| 122 | MeterFailReason.TIMEOUT); |
| 123 | } |
| 124 | }).build(); |
| 125 | |
| 126 | controller.addEventListener(listener); |
| 127 | controller.addListener(listener); |
| 128 | |
| 129 | controller.getSwitches().forEach((sw -> createStatsCollection(sw))); |
| 130 | } |
| 131 | |
| 132 | @Deactivate |
| 133 | public void deactivate() { |
| 134 | providerRegistry.unregister(this); |
Charles Chan | ecfdfb7 | 2015-11-24 19:05:50 -0800 | [diff] [blame] | 135 | collectors.values().forEach(MeterStatsCollector::stop); |
| 136 | collectors.clear(); |
alshabib | c791179 | 2015-07-30 17:55:30 -0700 | [diff] [blame] | 137 | controller.removeEventListener(listener); |
| 138 | controller.removeListener(listener); |
| 139 | providerService = null; |
| 140 | } |
| 141 | |
alshabib | bc37196 | 2015-07-09 22:26:21 -0700 | [diff] [blame] | 142 | @Override |
| 143 | public void performMeterOperation(DeviceId deviceId, MeterOperations meterOps) { |
alshabib | c791179 | 2015-07-30 17:55:30 -0700 | [diff] [blame] | 144 | Dpid dpid = Dpid.dpid(deviceId.uri()); |
| 145 | OpenFlowSwitch sw = controller.getSwitch(dpid); |
| 146 | if (sw == null) { |
| 147 | log.error("Unknown device {}", deviceId); |
| 148 | meterOps.operations().forEach(op -> |
| 149 | providerService.meterOperationFailed(op, |
| 150 | MeterFailReason.UNKNOWN_DEVICE) |
| 151 | ); |
| 152 | return; |
| 153 | } |
alshabib | bc37196 | 2015-07-09 22:26:21 -0700 | [diff] [blame] | 154 | |
alshabib | c791179 | 2015-07-30 17:55:30 -0700 | [diff] [blame] | 155 | meterOps.operations().forEach(op -> performOperation(sw, op)); |
alshabib | bc37196 | 2015-07-09 22:26:21 -0700 | [diff] [blame] | 156 | } |
| 157 | |
| 158 | @Override |
| 159 | public void performMeterOperation(DeviceId deviceId, MeterOperation meterOp) { |
alshabib | c791179 | 2015-07-30 17:55:30 -0700 | [diff] [blame] | 160 | Dpid dpid = Dpid.dpid(deviceId.uri()); |
| 161 | OpenFlowSwitch sw = controller.getSwitch(dpid); |
| 162 | if (sw == null) { |
| 163 | log.error("Unknown device {}", deviceId); |
| 164 | providerService.meterOperationFailed(meterOp, |
| 165 | MeterFailReason.UNKNOWN_DEVICE); |
| 166 | return; |
| 167 | } |
alshabib | bc37196 | 2015-07-09 22:26:21 -0700 | [diff] [blame] | 168 | |
alshabib | 7bb0501 | 2015-08-05 10:15:09 -0700 | [diff] [blame] | 169 | performOperation(sw, meterOp); |
| 170 | |
alshabib | bc37196 | 2015-07-09 22:26:21 -0700 | [diff] [blame] | 171 | } |
alshabib | c791179 | 2015-07-30 17:55:30 -0700 | [diff] [blame] | 172 | |
| 173 | private void performOperation(OpenFlowSwitch sw, MeterOperation op) { |
| 174 | |
| 175 | pendingOperations.put(op.meter().id().id(), op); |
| 176 | |
| 177 | |
| 178 | Meter meter = op.meter(); |
| 179 | MeterModBuilder builder = MeterModBuilder.builder(meter.id().id(), sw.factory()); |
| 180 | if (meter.isBurst()) { |
| 181 | builder.burst(); |
| 182 | } |
| 183 | builder.withBands(meter.bands()) |
| 184 | .withId(meter.id()) |
| 185 | .withRateUnit(meter.unit()); |
| 186 | |
| 187 | switch (op.type()) { |
| 188 | case ADD: |
| 189 | sw.sendMsg(builder.add()); |
| 190 | break; |
| 191 | case REMOVE: |
| 192 | sw.sendMsg(builder.remove()); |
| 193 | break; |
| 194 | case MODIFY: |
| 195 | sw.sendMsg(builder.modify()); |
| 196 | break; |
| 197 | default: |
| 198 | log.warn("Unknown Meter command {}; not sending anything", |
| 199 | op.type()); |
| 200 | providerService.meterOperationFailed(op, |
| 201 | MeterFailReason.UNKNOWN_COMMAND); |
| 202 | } |
| 203 | |
| 204 | } |
| 205 | |
| 206 | private void createStatsCollection(OpenFlowSwitch sw) { |
| 207 | if (isMeterSupported(sw)) { |
| 208 | MeterStatsCollector msc = new MeterStatsCollector(sw, POLL_INTERVAL); |
| 209 | msc.start(); |
| 210 | collectors.put(new Dpid(sw.getId()), msc); |
| 211 | } |
| 212 | } |
| 213 | |
Charles Chan | 14967c2 | 2015-12-07 11:11:50 -0800 | [diff] [blame] | 214 | // TODO: ONOS-3546 Support per device enabling/disabling via network config |
alshabib | c791179 | 2015-07-30 17:55:30 -0700 | [diff] [blame] | 215 | private boolean isMeterSupported(OpenFlowSwitch sw) { |
| 216 | if (sw.factory().getVersion() == OFVersion.OF_10 || |
| 217 | sw.factory().getVersion() == OFVersion.OF_11 || |
Charles Chan | 14967c2 | 2015-12-07 11:11:50 -0800 | [diff] [blame] | 218 | sw.factory().getVersion() == OFVersion.OF_12 || |
| 219 | sw.softwareDescription().equals("OF-DPA 2.0")) { |
alshabib | c791179 | 2015-07-30 17:55:30 -0700 | [diff] [blame] | 220 | return false; |
| 221 | } |
| 222 | |
| 223 | return true; |
| 224 | } |
| 225 | |
| 226 | private void pushMeterStats(Dpid dpid, OFStatsReply msg) { |
alshabib | 7bb0501 | 2015-08-05 10:15:09 -0700 | [diff] [blame] | 227 | DeviceId deviceId = DeviceId.deviceId(Dpid.uri(dpid)); |
alshabib | c791179 | 2015-07-30 17:55:30 -0700 | [diff] [blame] | 228 | |
alshabib | 7bb0501 | 2015-08-05 10:15:09 -0700 | [diff] [blame] | 229 | if (msg.getStatsType() == OFStatsType.METER) { |
| 230 | OFMeterStatsReply reply = (OFMeterStatsReply) msg; |
| 231 | Collection<Meter> meters = buildMeters(deviceId, reply.getEntries()); |
| 232 | //TODO do meter accounting here. |
| 233 | providerService.pushMeterMetrics(deviceId, meters); |
| 234 | } else if (msg.getStatsType() == OFStatsType.METER_CONFIG) { |
| 235 | OFMeterConfigStatsReply reply = (OFMeterConfigStatsReply) msg; |
| 236 | // FIXME: Map<Long, Meter> meters = collectMeters(deviceId, reply); |
| 237 | } |
| 238 | |
| 239 | } |
| 240 | |
| 241 | private Map<Long, Meter> collectMeters(DeviceId deviceId, |
| 242 | OFMeterConfigStatsReply reply) { |
| 243 | return Maps.newHashMap(); |
| 244 | //TODO: Needs a fix to be applied to loxi MeterConfig stat is incorrect |
| 245 | } |
| 246 | |
| 247 | private Collection<Meter> buildMeters(DeviceId deviceId, |
| 248 | List<OFMeterStats> entries) { |
| 249 | return entries.stream().map(stat -> { |
| 250 | DefaultMeter.Builder builder = DefaultMeter.builder(); |
| 251 | Collection<Band> bands = buildBands(stat.getBandStats()); |
| 252 | builder.forDevice(deviceId) |
alshabib | 58fe6dc | 2015-08-19 17:16:13 -0700 | [diff] [blame] | 253 | .withId(MeterId.meterId(stat.getMeterId())) |
alshabib | 7bb0501 | 2015-08-05 10:15:09 -0700 | [diff] [blame] | 254 | //FIXME: need to encode appId in meter id, but that makes |
| 255 | // things a little annoying for debugging |
| 256 | .fromApp(coreService.getAppId("org.onosproject.core")) |
| 257 | .withBands(bands); |
| 258 | DefaultMeter meter = builder.build(); |
| 259 | meter.setState(MeterState.ADDED); |
| 260 | meter.setLife(stat.getDurationSec()); |
| 261 | meter.setProcessedBytes(stat.getByteInCount().getValue()); |
| 262 | meter.setProcessedPackets(stat.getPacketInCount().getValue()); |
| 263 | meter.setReferenceCount(stat.getFlowCount()); |
| 264 | |
| 265 | // marks the meter as seen on the dataplane |
| 266 | pendingOperations.invalidate(stat.getMeterId()); |
| 267 | return meter; |
| 268 | }).collect(Collectors.toSet()); |
| 269 | } |
| 270 | |
| 271 | private Collection<Band> buildBands(List<OFMeterBandStats> bandStats) { |
| 272 | return bandStats.stream().map(stat -> { |
| 273 | DefaultBand band = DefaultBand.builder().build(); |
| 274 | band.setBytes(stat.getByteBandCount().getValue()); |
| 275 | band.setPackets(stat.getPacketBandCount().getValue()); |
| 276 | return band; |
| 277 | }).collect(Collectors.toSet()); |
alshabib | c791179 | 2015-07-30 17:55:30 -0700 | [diff] [blame] | 278 | } |
| 279 | |
| 280 | private void signalMeterError(OFMeterModFailedErrorMsg meterError, |
| 281 | MeterOperation op) { |
| 282 | switch (meterError.getCode()) { |
| 283 | case UNKNOWN: |
| 284 | providerService.meterOperationFailed(op, |
| 285 | MeterFailReason.UNKNOWN_DEVICE); |
| 286 | break; |
| 287 | case METER_EXISTS: |
| 288 | providerService.meterOperationFailed(op, |
| 289 | MeterFailReason.EXISTING_METER); |
| 290 | break; |
| 291 | case INVALID_METER: |
| 292 | providerService.meterOperationFailed(op, |
| 293 | MeterFailReason.INVALID_METER); |
| 294 | break; |
| 295 | case UNKNOWN_METER: |
| 296 | providerService.meterOperationFailed(op, |
| 297 | MeterFailReason.UNKNOWN); |
| 298 | break; |
| 299 | case BAD_COMMAND: |
| 300 | providerService.meterOperationFailed(op, |
| 301 | MeterFailReason.UNKNOWN_COMMAND); |
| 302 | break; |
| 303 | case BAD_FLAGS: |
| 304 | providerService.meterOperationFailed(op, |
| 305 | MeterFailReason.UNKNOWN_FLAGS); |
| 306 | break; |
| 307 | case BAD_RATE: |
| 308 | providerService.meterOperationFailed(op, |
| 309 | MeterFailReason.BAD_RATE); |
| 310 | break; |
| 311 | case BAD_BURST: |
| 312 | providerService.meterOperationFailed(op, |
| 313 | MeterFailReason.BAD_BURST); |
| 314 | break; |
| 315 | case BAD_BAND: |
| 316 | providerService.meterOperationFailed(op, |
| 317 | MeterFailReason.BAD_BAND); |
| 318 | break; |
| 319 | case BAD_BAND_VALUE: |
| 320 | providerService.meterOperationFailed(op, |
| 321 | MeterFailReason.BAD_BAND_VALUE); |
| 322 | break; |
| 323 | case OUT_OF_METERS: |
| 324 | providerService.meterOperationFailed(op, |
| 325 | MeterFailReason.OUT_OF_METERS); |
| 326 | break; |
| 327 | case OUT_OF_BANDS: |
| 328 | providerService.meterOperationFailed(op, |
| 329 | MeterFailReason.OUT_OF_BANDS); |
| 330 | break; |
| 331 | default: |
| 332 | providerService.meterOperationFailed(op, |
| 333 | MeterFailReason.UNKNOWN); |
| 334 | } |
| 335 | } |
| 336 | |
| 337 | private class InternalMeterListener |
| 338 | implements OpenFlowSwitchListener, OpenFlowEventListener { |
| 339 | @Override |
| 340 | public void handleMessage(Dpid dpid, OFMessage msg) { |
| 341 | switch (msg.getType()) { |
| 342 | case STATS_REPLY: |
| 343 | pushMeterStats(dpid, (OFStatsReply) msg); |
| 344 | break; |
| 345 | case ERROR: |
| 346 | OFErrorMsg error = (OFErrorMsg) msg; |
| 347 | if (error.getErrType() == OFErrorType.METER_MOD_FAILED) { |
| 348 | MeterOperation op = |
| 349 | pendingOperations.getIfPresent(error.getXid()); |
| 350 | pendingOperations.invalidate(error.getXid()); |
| 351 | if (op == null) { |
| 352 | log.warn("Unknown Meter operation failed {}", error); |
| 353 | } else { |
| 354 | OFMeterModFailedErrorMsg meterError = |
| 355 | (OFMeterModFailedErrorMsg) error; |
| 356 | signalMeterError(meterError, op); |
| 357 | } |
| 358 | } |
| 359 | break; |
| 360 | default: |
| 361 | break; |
| 362 | } |
| 363 | |
| 364 | } |
| 365 | |
| 366 | @Override |
| 367 | public void switchAdded(Dpid dpid) { |
| 368 | createStatsCollection(controller.getSwitch(dpid)); |
| 369 | } |
| 370 | |
| 371 | @Override |
| 372 | public void switchRemoved(Dpid dpid) { |
| 373 | MeterStatsCollector msc = collectors.remove(dpid); |
| 374 | if (msc != null) { |
| 375 | msc.stop(); |
| 376 | } |
| 377 | } |
| 378 | |
| 379 | @Override |
| 380 | public void switchChanged(Dpid dpid) { |
| 381 | |
| 382 | } |
| 383 | |
| 384 | @Override |
| 385 | public void portChanged(Dpid dpid, OFPortStatus status) { |
| 386 | |
| 387 | } |
| 388 | |
| 389 | @Override |
| 390 | public void receivedRoleReply(Dpid dpid, RoleState requested, RoleState response) { |
| 391 | |
| 392 | } |
| 393 | } |
| 394 | |
| 395 | |
| 396 | |
alshabib | e27055b | 2015-07-09 21:43:10 -0700 | [diff] [blame] | 397 | } |