commit ffe1a33da18d69c989b826594756667eedb7ecdd
author Ray Milkey <ray@opennetworking.org> Wed Jan 24 10:41:14 2018 -0800
committer Thomas Vachuska <tom@opennetworking.org> Thu Jan 25 00:48:10 2018 +0000
tree 47de92b16dd248664c810eb5d11153f8f4609093
parent 9539082d93dc23cff4588d2a4774e1b2db79a573

SONAR suggestions - more blocker bugs
- fixed some cases where pointers could be null
- fixed some booleans statements known to always be
  true or false

Change-Id: I0d67c1794b37deeccffda1f4ad0f447857e2a5d1

apps/dhcprelay/src/main/java/org/onosproject/dhcprelay/Dhcp6HandlerImpl.java

diff --git a/apps/dhcprelay/src/main/java/org/onosproject/dhcprelay/Dhcp6HandlerImpl.java b/apps/dhcprelay/src/main/java/org/onosproject/dhcprelay/Dhcp6HandlerImpl.java
index 2990e5a..0cb3468 100644
--- a/apps/dhcprelay/src/main/java/org/onosproject/dhcprelay/Dhcp6HandlerImpl.java
+++ b/apps/dhcprelay/src/main/java/org/onosproject/dhcprelay/Dhcp6HandlerImpl.java
@@ -626,15 +626,17 @@
             }
         }
 
-        record.getV6Counters().incrementCounter(dhcp6HandlerUtil.getMsgTypeStr(leafMsgType));
-        record.addLocation(new HostLocation(location, System.currentTimeMillis()));
-        record.ip6Status(DHCP6.MsgType.getType(leafMsgType));
-        record.setDirectlyConnected(directConnFlag);
-        if (!directConnFlag) {
-            // Update gateway mac address if the host is not directly connected
-            record.nextHop(srcMac);
+        if (record != null) {
+            record.getV6Counters().incrementCounter(dhcp6HandlerUtil.getMsgTypeStr(leafMsgType));
+            record.addLocation(new HostLocation(location, System.currentTimeMillis()));
+            record.ip6Status(DHCP6.MsgType.getType(leafMsgType));
+            record.setDirectlyConnected(directConnFlag);
+            if (!directConnFlag) {
+                // Update gateway mac address if the host is not directly connected
+                record.nextHop(srcMac);
+            }
+            record.updateLastSeen();
         }
-        record.updateLastSeen();
         dhcpRelayStore.updateDhcpRecord(leafHostId, record);
         // TODO Use AtomicInteger for the counters
         try {