commit fd93b4a6f89d055aa66d350a2c6ec39be23ac38f
author Jordan Halterman <jordan@opennetworking.org> Fri Jan 04 13:43:39 2019 -0800
committer Ray Milkey <ray@opennetworking.org> Tue Jan 08 19:54:27 2019 +0000
tree a27f6575fcf257d62b338ca2e25a13eb9d98e156
parent efe8877e438b9126f502daff580609752f5fe95f

Always send device status updates to peers

Change-Id: I0ff94e7d5f059e5e6dc8f955aa67c68926fd85d6

core/store/dist/src/main/java/org/onosproject/store/device/impl/GossipDeviceStore.java

diff --git a/core/store/dist/src/main/java/org/onosproject/store/device/impl/GossipDeviceStore.java b/core/store/dist/src/main/java/org/onosproject/store/device/impl/GossipDeviceStore.java
index 32a9be6..8116461 100644
--- a/core/store/dist/src/main/java/org/onosproject/store/device/impl/GossipDeviceStore.java
+++ b/core/store/dist/src/main/java/org/onosproject/store/device/impl/GossipDeviceStore.java
@@ -463,11 +463,9 @@
 
     private DeviceEvent markOffline(DeviceId deviceId, Timestamp timestamp) {
         final DeviceEvent event = markOfflineInternal(deviceId, timestamp);
-        if (event != null) {
-            log.debug("Notifying peers of a device offline topology event for deviceId: {} {}",
-                     deviceId, timestamp);
-            notifyPeers(new InternalDeviceStatusChangeEvent(deviceId, timestamp, false));
-        }
+        // Always notify peers of device availability change and allow them to determine the latest state.
+        log.debug("Notifying peers of a device offline topology event for deviceId: {} {}", deviceId, timestamp);
+        notifyPeers(new InternalDeviceStatusChangeEvent(deviceId, timestamp, false));
         return event;
     }
 
@@ -524,9 +522,9 @@
      */
     private DeviceEvent markOnline(DeviceId deviceId, Timestamp timestamp, boolean notifyPeers) {
         final DeviceEvent event = markOnlineInternal(deviceId, timestamp);
-        if (event != null && notifyPeers) {
-            log.debug("Notifying peers of a device online topology event for deviceId: {} {}",
-                      deviceId, timestamp);
+        // Always notify peers of device availability change and allow them to determine the latest state.
+        if (notifyPeers) {
+            log.debug("Notifying peers of a device online topology event for deviceId: {} {}", deviceId, timestamp);
             notifyPeers(new InternalDeviceStatusChangeEvent(deviceId, timestamp, true));
         }
         return event;