| commit | fd4f8d3861edf824fdef7d542b96d880e0a4f120 | [log] [tgz] |
|---|---|---|
| author | Ray Milkey <ray@opennetworking.org> | Wed Jan 17 15:24:52 2018 -0800 |
| committer | Ray Milkey <ray@opennetworking.org> | Thu Jan 25 23:21:50 2018 +0000 |
| tree | ec6add779a704e23bb49118db22c5594e7c58797 | |
| parent | 5a45bbc7c376081d7084c611535ec8f25216cbeb [diff] [blame] |
Sonar suggestions - fixes to potential null pointer dereferences Change-Id: I4e350a9d72a9322971d5d4f831f1bdf167986b87
diff --git a/drivers/default/src/main/java/org/onosproject/driver/pipeline/SoftRouterPipeline.java b/drivers/default/src/main/java/org/onosproject/driver/pipeline/SoftRouterPipeline.java index 03a77ba..9ca9420 100644 --- a/drivers/default/src/main/java/org/onosproject/driver/pipeline/SoftRouterPipeline.java +++ b/drivers/default/src/main/java/org/onosproject/driver/pipeline/SoftRouterPipeline.java
@@ -270,6 +270,12 @@ } + if (v == null || e == null) { + log.warn("Soft Router Pipeline ETH_DST and/or VLAN_ID not specified"); + fail(filt, ObjectiveError.BADPARAMS); + return; + } + log.debug("Modifying Port/VLAN/MAC filtering rules in filter table: {}/{}/{}", p.port(), v.vlanId(), e.mac()); TrafficSelector.Builder selector = DefaultTrafficSelector.builder();