Gitiles
Code Review Sign In
gerrit.onosproject.org / onos / fa6aa276673022525fb64a44e8daec1cd1a227f9
commitfa6aa276673022525fb64a44e8daec1cd1a227f9[log] [tgz]
authorDmytro Titov <d.titov@inango-systems.com>Mon Jun 10 18:07:52 2019 +0500
committerPier Luigi Ventre <pier@opennetworking.org>Mon Jun 17 12:37:44 2019 +0000
tree89a4afb96aefa3d83db3fc1149f6c66050dbd602
parentf1a04004363d2c59108ad3ca9277c09ec1a2167a [diff]
[ONOS-8000] Use passed length for Data payload

Current code can broke a packet during serialization due to bug in
the "Data.deserialize" call. According to the IEEE Std 802.3 standard
an ethernet frame can not have the payload less then 46 bytes. When
the ethernet frame have shorter payload it padded with zeros.

We observed that for short UDP packets deserialize methods for both
the IPv4 and UDP packets calculate length correctly, but the Data
payload deserialization method ignores passed length and takess all
data up to end of the buffer with ethernet frame.

Suggested changes change the Data deserialization method to use only
passed "length" bytes instead of whole remaining "data" buffer.

Change-Id: I6b93458a8925a0924f3830e3a5d5763369e8ea92
(cherry picked from commit a1010de8ea7c5228d35eae62875e20d02555cb24)
2 files changed
tree: 89a4afb96aefa3d83db3fc1149f6c66050dbd602
  1. .bazelrc
  2. .dockerignore
  3. .github/
  4. .gitignore
  5. .gitreview
  6. BUILD
  7. Dockerfile
  8. LICENSE.txt
  9. README.md
  10. WORKSPACE
  11. apps/
  12. cli/
  13. core/
  14. docs/
  15. drivers/
  16. lib/
  17. models/
  18. pipelines/
  19. protocols/
  20. providers/
  21. tools/
  22. utils/
  23. web/
README.md

ONOS : Open Network Operating System

What is ONOS?

ONOS is the only SDN controller platform that supports the transition from legacy “brown field” networks to SDN “green field” networks. This enables exciting new capabilities, and disruptive deployment and operational cost points for network operators.

Top-Level Features

  • High availability through clustering and distributed state management.
  • Scalability through clustering and sharding of network device control.
  • Performance that is good for a first release, and which has an architecture that will continue to support improvements.
  • Northbound abstractions for a global network view, network graph, and application intents.
  • Pluggable southbound for support of OpenFlow and new or legacy protocols.
  • Graphical user interface to view multi-layer topologies and inspect elements of the topology.
  • REST API for access to Northbound abstractions as well as CLI commands.
  • CLI for debugging.
  • Support for both proactive and reactive flow setup.
  • SDN-IP application to support interworking with traditional IP networks controlled by distributed routing protocols such as BGP.
  • IP-Optical use case demonstration.

Getting started

Dependencies

The following packages are reuqired:

  • git
  • zip
  • curl
  • unzip
  • python2.7
  • Oracle JDK8

To install Oracle JDK8, use following commands (Ubuntu):

$ sudo apt-get install software-properties-common -y && \
  sudo add-apt-repository ppa:webupd8team/java -y && \
  sudo apt-get update && \
  echo "oracle-java8-installer shared/accepted-oracle-license-v1-1 select true" | sudo debconf-set-selections && \
  sudo apt-get install oracle-java8-installer oracle-java8-set-default -y

Build ONOS from source

ONOS is built with Bazel, an open-source build tool developed by Google. ONOS supports Bazel 0.17 You can download it from official website or package manager (e.g. apt, brew...)

  1. Clone the code from ONOS gerrit repository
$ git clone https://gerrit.onosproject.org/onos
  1. Add ONOS developer environment to your bash profile, no need to do this step again if you had done this before
$ cd onos
$ cat << EOF >> ~/.bash_profile
export ONOS_ROOT="`pwd`"
source $ONOS_ROOT/tools/dev/bash_profile
EOF
$ . ~/.bash_profile
  1. Build ONOS with Bazel
$ cd $ONOS_ROOT
$ bazel build onos

Start ONOS on local machine

To run ONOS locally on the development machine, simply run the following command:

$ bazel run onos-local [-- [clean] [debug]]

or simpler one:

$ ok [clean] [debug]

The above command will create a local installation from the onos.tar.gz file (re-building it if necessary) and will start the ONOS server in the background. In the foreground, it will display a continuous view of the ONOS (Apache Karaf) log file. Options following the double-dash (–) are passed through to the ONOS Apache Karaf and can be omitted. Here, the clean option forces a clean installation of ONOS and the debug option means that the default debug port 5005 will be available for attaching a remote debugger.

Interacting with ONOS

To access ONOS UI, use browser to open http://localhost:8181/onos/ui or use onos-gui localhost command

The default username and password is onos/rocks

To attach to the ONOS CLI console, run:

$ onos localhost

Unit Tests

To run ONOS unit tests, including code Checkstyle validation, run the following command:

$ bazel query 'tests(//...)' | xargs bazel test

Or better yet, to run code Checkstyle and all unit tests use the following convenience alias:

$ ot

Contributing

ONOS code is hosted and maintained using Gerrit.

Code on GitHub is only a mirror. The ONOS project does NOT accept code through pull requests on GitHub.

To contribute to ONOS, please refer to Sample Gerrit Workflow. It should includes most of the things you'll need to get your contribution started!

More information

For more information, please check out our wiki page or mailing lists:

License

ONOS (Open Network Operating System) is published under Apache License 2.0