[SDFAB-98] Improve logging in several ONOS subsystems
Change-Id: Ic9a20af6da27c3cc5c219657f10999f6804b9334
diff --git a/core/net/src/main/java/org/onosproject/net/pi/impl/PiPipeconfWatchdogManager.java b/core/net/src/main/java/org/onosproject/net/pi/impl/PiPipeconfWatchdogManager.java
index 103d6cf..6dea30e 100644
--- a/core/net/src/main/java/org/onosproject/net/pi/impl/PiPipeconfWatchdogManager.java
+++ b/core/net/src/main/java/org/onosproject/net/pi/impl/PiPipeconfWatchdogManager.java
@@ -271,6 +271,7 @@
final PiPipelineProgrammable pipelineProg = device.as(PiPipelineProgrammable.class);
final DeviceHandshaker handshaker = device.as(DeviceHandshaker.class);
if (!handshaker.hasConnection()) {
+ log.warn("There is no connectivity with {}", device.id());
return false;
}
if (Futures.getUnchecked(pipelineProg.isPipeconfSet(pipeconf)) &&
diff --git a/protocols/grpc/ctl/src/main/java/org/onosproject/grpc/ctl/AbstractGrpcClientController.java b/protocols/grpc/ctl/src/main/java/org/onosproject/grpc/ctl/AbstractGrpcClientController.java
index f7c33c3..5b3153c 100644
--- a/protocols/grpc/ctl/src/main/java/org/onosproject/grpc/ctl/AbstractGrpcClientController.java
+++ b/protocols/grpc/ctl/src/main/java/org/onosproject/grpc/ctl/AbstractGrpcClientController.java
@@ -101,7 +101,7 @@
"A %s client already exists for %s", serviceName, deviceId));
}
- log.debug("Creating {}...", clientName(deviceId));
+ log.info("Creating {}...", clientName(deviceId));
final C client;
try {
@@ -135,7 +135,7 @@
withDeviceLock(() -> {
final C client = clients.remove(deviceId);
if (client != null) {
- log.debug("Removing {}...", clientName(deviceId));
+ log.info("Removing {}...", clientName(deviceId));
client.shutdown();
}
return null;
diff --git a/protocols/grpc/ctl/src/main/java/org/onosproject/grpc/ctl/GrpcChannelControllerImpl.java b/protocols/grpc/ctl/src/main/java/org/onosproject/grpc/ctl/GrpcChannelControllerImpl.java
index 9e2321e..ca43cac 100644
--- a/protocols/grpc/ctl/src/main/java/org/onosproject/grpc/ctl/GrpcChannelControllerImpl.java
+++ b/protocols/grpc/ctl/src/main/java/org/onosproject/grpc/ctl/GrpcChannelControllerImpl.java
@@ -210,6 +210,7 @@
channelLocks.get(channelUri).lock();
try {
+ log.info("Destroying gRPC channel {}...", channelUri);
final ManagedChannel channel = channels.remove(channelUri);
if (channel != null) {
shutdownNowAndWait(channel, channelUri);