commit f03f6e9eff44925e80aa4e9f5b82d53d942a6eb7
author Carmelo Cascone <carmelo@opennetworking.org> Wed Apr 04 11:39:39 2018 -0700
committer Carmelo Cascone <carmelo@opennetworking.org> Wed Apr 04 19:01:06 2018 +0000
tree 2a9c91bb259332b77eecd6b722012767d1bd2a7b
parent 4310f6e4954d41a39e0bb9a6cd8f048ca3ab81ad

Build PI table entries with EMPTY match key by default

Change-Id: I79d1527c79799f1a8291c030c0117e6ba04cc00a

core/api/src/main/java/org/onosproject/net/pi/runtime/PiTableEntry.java

diff --git a/core/api/src/main/java/org/onosproject/net/pi/runtime/PiTableEntry.java b/core/api/src/main/java/org/onosproject/net/pi/runtime/PiTableEntry.java
index 5770c6b..a836e15 100644
--- a/core/api/src/main/java/org/onosproject/net/pi/runtime/PiTableEntry.java
+++ b/core/api/src/main/java/org/onosproject/net/pi/runtime/PiTableEntry.java
@@ -168,7 +168,7 @@
     public static final class Builder {
 
         private PiTableId tableId;
-        private PiMatchKey matchKey;
+        private PiMatchKey matchKey = PiMatchKey.EMPTY;
         private PiTableAction tableAction;
         private long cookie = 0;
         private int priority = NO_PRIORITY;
@@ -185,7 +185,7 @@
          * @return this
          */
         public Builder forTable(PiTableId tableId) {
-            this.tableId = checkNotNull(tableId);
+            this.tableId = checkNotNull(tableId, "Table ID cannot be null");
             return this;
         }
 
@@ -196,18 +196,19 @@
          * @return this
          */
         public Builder withAction(PiTableAction tableAction) {
-            this.tableAction = checkNotNull(tableAction);
+            this.tableAction = checkNotNull(tableAction, "Action cannot be null");
             return this;
         }
 
         /**
-         * Sets the match key of this table entry.
+         * Sets the match key of this table entry. By default, the match key is
+         * {@link PiMatchKey#EMPTY}, i.e. any match.
          *
          * @param matchKey match key
          * @return this
          */
         public Builder withMatchKey(PiMatchKey matchKey) {
-            this.matchKey = matchKey;
+            this.matchKey = checkNotNull(matchKey, "Match key cannot be null");
             return this;
         }
 
@@ -253,6 +254,7 @@
          */
         public PiTableEntry build() {
             checkNotNull(tableId);
+            checkNotNull(matchKey);
             checkNotNull(tableAction);
             return new PiTableEntry(tableId, matchKey, tableAction, cookie, priority, timeout);
         }