commit | e5e0c9ae38e96316ddc605ee816935a677047b15 | [log] [tgz] |
---|---|---|
author | Charles Chan <rascov@gmail.com> | Fri Mar 30 12:11:34 2018 -0700 |
committer | Charles Chan <charles@opennetworking.org> | Mon Apr 02 01:09:01 2018 +0000 |
tree | 4a0acc474887abbc1f9d43c94c346d862288e7b6 | |
parent | 29d959805cf257ce0facbf2bb1500d6fda48d0b1 [diff] [blame] |
Better error handling Change-Id: Iac5934a89b177f4e0207a6ecc2e2f0731aca115e
diff --git a/apps/segmentrouting/app/src/main/java/org/onosproject/segmentrouting/ArpHandler.java b/apps/segmentrouting/app/src/main/java/org/onosproject/segmentrouting/ArpHandler.java index b3a0aca..af62525 100644 --- a/apps/segmentrouting/app/src/main/java/org/onosproject/segmentrouting/ArpHandler.java +++ b/apps/segmentrouting/app/src/main/java/org/onosproject/segmentrouting/ArpHandler.java
@@ -102,6 +102,11 @@ // ARP request for router. Send ARP reply. if (isArpForRouter(pkt)) { MacAddress targetMac = config.getRouterMacForAGatewayIp(pkt.target().getIp4Address()); + if (targetMac == null) { + log.warn("Router MAC of {} is not configured. Cannot handle ARP request from {}", + pkt.inPort().deviceId(), pkt.sender()); + return; + } sendResponse(pkt, targetMac, hostService); } else { // NOTE: Ignore ARP packets except those target for the router