| commit | e559bcf45dff0bbf9a392629b53db6bc052de23a | [log] [tgz] |
|---|---|---|
| author | Ray Milkey <ray@opennetworking.org> | Fri Dec 15 15:58:12 2017 -0800 |
| committer | Ray Milkey <ray@opennetworking.org> | Mon Dec 18 22:51:08 2017 +0000 |
| tree | 4000cddc5da79a28da25002048301d83906c0adb | |
| parent | faed9f3b44c67ae9067dca1d3ed4db1deb0298cb [diff] |
Sonar suggestion - don't use bit operator in a boolean expression Change-Id: I69e254ffea0c72a040077d6e6a13c326d44c1197
diff --git a/utils/misc/src/main/java/org/onlab/packet/PacketUtils.java b/utils/misc/src/main/java/org/onlab/packet/PacketUtils.java index d4ec84d..81b06e0 100644 --- a/utils/misc/src/main/java/org/onlab/packet/PacketUtils.java +++ b/utils/misc/src/main/java/org/onlab/packet/PacketUtils.java
@@ -39,7 +39,7 @@ public static void checkBufferLength(int byteLength, int offset, int length) throws DeserializationException { boolean ok = (offset >= 0 && offset < byteLength); - ok = ok & (length >= 0 && offset + length <= byteLength); + ok = ok && (length >= 0 && offset + length <= byteLength); if (!ok) { throw new DeserializationException("Unable to read " + length + " bytes from a "