Some class of constraints should not be used for link cost evaluation.
ONOS-6021
Current ConnectivityIntentCompiler simply picks first non-negative cost as Link cost value.
Some class of constraints are used to express Path viability or IntentCompiler's behavior.
Those constraints tend to returns fixed arbitrary non-negative link cost, which probably is not the best option to be used as Link cost during path computation.
This patch will:
- Introduce base class for constraints which should not influence Link cost.
- Introduce base class for constraints which should not influence Link cost or Path viability.
- Exclude above classes from link cost computation in ConnectivityIntentCompiler
MarkerConstraint
base class for Constraints,
which is not meant to influence Link cost or Path viability.
PathViablityConstraint
base class for Constraints,
which is not meant to influence Link cost.
Change-Id: Ice8b83a18cfe3bf5a68c25a853667bfaedb2b1a1
diff --git a/core/api/src/main/java/org/onosproject/net/intent/constraint/MarkerConstraint.java b/core/api/src/main/java/org/onosproject/net/intent/constraint/MarkerConstraint.java
new file mode 100644
index 0000000..bc2c107
--- /dev/null
+++ b/core/api/src/main/java/org/onosproject/net/intent/constraint/MarkerConstraint.java
@@ -0,0 +1,57 @@
+/*
+ * Copyright 2016-present Open Networking Laboratory
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.onosproject.net.intent.constraint;
+
+import org.onosproject.net.Link;
+import org.onosproject.net.Path;
+import org.onosproject.net.intent.Constraint;
+import org.onosproject.net.intent.ResourceContext;
+
+/**
+ * Abstract Constraint for constraints not intended to influence
+ * individual link cost or path validity.
+ */
+public abstract class MarkerConstraint implements Constraint {
+
+ @Override
+ public final double cost(Link link, ResourceContext context) {
+ // random value, should never be used.
+ return 1.0;
+ }
+
+ @Override
+ public final boolean validate(Path path, ResourceContext context) {
+ return true;
+ }
+
+ @Override
+ public int hashCode() {
+ return this.getClass().hashCode();
+ }
+
+ @Override
+ public boolean equals(Object obj) {
+ if (this == obj) {
+ return true;
+ }
+ return obj != null && this.getClass() == obj.getClass();
+ }
+
+ @Override
+ public String toString() {
+ return getClass().getSimpleName().replace("Constraint", "");
+ }
+}