Added ability to configure GUI traffic refresh rate
Change-Id: Iceb1196a20c16f09218218da2e095fbe9644bb04
(cherry picked from commit a5e986d31cde1fb5b4f5c051b5a1fb42f597f68a)
diff --git a/web/gui/src/main/java/org/onosproject/ui/impl/UiExtensionManager.java b/web/gui/src/main/java/org/onosproject/ui/impl/UiExtensionManager.java
index 73de4c1..d47367b 100644
--- a/web/gui/src/main/java/org/onosproject/ui/impl/UiExtensionManager.java
+++ b/web/gui/src/main/java/org/onosproject/ui/impl/UiExtensionManager.java
@@ -33,6 +33,7 @@
import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
import org.onlab.util.Tools;
+import org.onosproject.cfg.ComponentConfigService;
import org.onosproject.mastership.MastershipService;
import org.onosproject.store.serializers.KryoNamespaces;
import org.onosproject.store.service.ConsistentMap;
@@ -61,9 +62,12 @@
import org.onosproject.ui.impl.topo.model.UiSharedTopologyModel;
import org.onosproject.ui.lion.LionBundle;
import org.onosproject.ui.lion.LionUtils;
+import org.onosproject.ui.topo.AbstractTopoMonitor;
+import org.osgi.service.component.ComponentContext;
import org.osgi.service.component.annotations.Activate;
import org.osgi.service.component.annotations.Component;
import org.osgi.service.component.annotations.Deactivate;
+import org.osgi.service.component.annotations.Modified;
import org.osgi.service.component.annotations.Reference;
import org.osgi.service.component.annotations.ReferenceCardinality;
import org.slf4j.Logger;
@@ -71,6 +75,7 @@
import java.math.BigInteger;
import java.security.SecureRandom;
+import java.util.Dictionary;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Locale;
@@ -88,13 +93,23 @@
import static org.onosproject.security.AppPermission.Type.UI_WRITE;
import static org.onosproject.ui.UiView.Category.NETWORK;
import static org.onosproject.ui.UiView.Category.PLATFORM;
+import static org.onosproject.ui.impl.OsgiPropertyConstants.TRAFFIC_REFRESH_MS;
+import static org.onosproject.ui.impl.OsgiPropertyConstants.TRAFFIC_REFRESH_MS_DEFAULT;
import static org.onosproject.ui.impl.lion.BundleStitcher.generateBundles;
/**
* Manages the user interface extensions.
*/
-@Component(immediate = true, service = { UiExtensionService.class, UiPreferencesService.class, SpriteService.class,
- UiTokenService.class })
+@Component(immediate = true,
+ service = {
+ UiExtensionService.class,
+ UiPreferencesService.class,
+ SpriteService.class,
+ UiTokenService.class
+ },
+ property = {
+ TRAFFIC_REFRESH_MS + ":Integer=" + TRAFFIC_REFRESH_MS_DEFAULT,
+ })
public class UiExtensionManager
implements UiExtensionService, UiPreferencesService, SpriteService,
UiTokenService {
@@ -156,6 +171,9 @@
protected StorageService storageService;
@Reference(cardinality = ReferenceCardinality.MANDATORY)
+ protected ComponentConfigService cfgService;
+
+ @Reference(cardinality = ReferenceCardinality.MANDATORY)
private UiSharedTopologyModel sharedModel;
// User preferences
@@ -178,6 +196,7 @@
private LionBundle navLion;
+ protected int trafficRefreshMs = TRAFFIC_REFRESH_MS_DEFAULT;
private String lionNavText(String id) {
return navLion.getValue("nav_item_" + id);
@@ -281,7 +300,7 @@
@Activate
- public void activate() {
+ public void activate(ComponentContext context) {
Serializer serializer = Serializer.using(KryoNamespaces.API,
ObjectNode.class, ArrayNode.class,
JsonNodeFactory.class, LinkedHashMap.class,
@@ -303,6 +322,7 @@
.withRelaxedReadConsistency()
.build();
tokens = tokensConsistentMap.asJavaMap();
+ cfgService.registerProperties(getClass());
register(core);
@@ -310,7 +330,8 @@
}
@Deactivate
- public void deactivate() {
+ public void deactivate(ComponentContext context) {
+ cfgService.unregisterProperties(getClass(), false);
prefsConsistentMap.removeListener(prefsListener);
eventHandlingExecutor.shutdown();
UiWebSocketServlet.closeAll();
@@ -318,6 +339,20 @@
log.info("Stopped");
}
+ @Modified
+ protected void modified(ComponentContext context) {
+ Dictionary<?, ?> properties = context.getProperties();
+ Integer trafficRefresh = Tools.getIntegerProperty(properties, TRAFFIC_REFRESH_MS);
+
+ if (trafficRefresh != null && trafficRefresh > 10) {
+ AbstractTopoMonitor.setTrafficPeriod(trafficRefresh);
+ } else if (trafficRefresh != null) {
+ log.warn("trafficRefresh must be greater than 10");
+ }
+
+ log.info("Settings: trafficRefresh={}", trafficRefresh);
+ }
+
@Override
public synchronized void register(UiExtension extension) {
checkPermission(UI_WRITE);