commit e090a422769f789e23e4e0511615d4b954376ae4
author Sho SHIMIZU <sshimizu@us.fujitsu.com> Fri Sep 04 17:35:49 2015 -0700
committer Gerrit Code Review <gerrit@onlab.us> Sat Sep 05 00:57:26 2015 +0000
tree 0a742bdb951594a3fa4a401c966e892a8a20a1d7
parent e79b02520b847c3de2dc806d44b89cb18e9a5f97

Replace useless assertion with type check by instanceof

Change-Id: I6b80e42e47579914776497f2314b9aa75d98dabf

pcep/pcepio/src/test/java/org/onosproject/pcepio/PcepOpenMsgTest.java

diff --git a/pcep/pcepio/src/test/java/org/onosproject/pcepio/PcepOpenMsgTest.java b/pcep/pcepio/src/test/java/org/onosproject/pcepio/PcepOpenMsgTest.java
index 435316e..1aff496 100644
--- a/pcep/pcepio/src/test/java/org/onosproject/pcepio/PcepOpenMsgTest.java
+++ b/pcep/pcepio/src/test/java/org/onosproject/pcepio/PcepOpenMsgTest.java
@@ -16,8 +16,8 @@
 package org.onosproject.pcepio;
 
 import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.instanceOf;
 import static org.hamcrest.core.Is.is;
-import static org.hamcrest.core.IsSame.sameInstance;
 
 import org.jboss.netty.buffer.ChannelBuffer;
 import org.jboss.netty.buffer.ChannelBuffers;
@@ -54,7 +54,7 @@
 
         message = reader.readFrom(buffer);
 
-        assertThat(message, sameInstance((PcepOpenMsg) message));
+        assertThat(message, instanceOf(PcepOpenMsg.class));
         ChannelBuffer buf = ChannelBuffers.dynamicBuffer();
         message.writeTo(buf);
         testOpenMsg = buf.array();
@@ -86,7 +86,7 @@
 
         message = reader.readFrom(buffer);
 
-        assertThat(message, sameInstance((PcepOpenMsg) message));
+        assertThat(message, instanceOf(PcepOpenMsg.class));
         ChannelBuffer buf = ChannelBuffers.dynamicBuffer();
         message.writeTo(buf);
         testOpenMsg = buf.array();
@@ -119,7 +119,7 @@
 
         message = reader.readFrom(buffer);
 
-        assertThat(message, sameInstance((PcepOpenMsg) message));
+        assertThat(message, instanceOf(PcepOpenMsg.class));
         ChannelBuffer buf = ChannelBuffers.dynamicBuffer();
         message.writeTo(buf);
         testOpenMsg = buf.array();
@@ -152,7 +152,7 @@
 
         message = reader.readFrom(buffer);
 
-        assertThat(message, sameInstance((PcepOpenMsg) message));
+        assertThat(message, instanceOf(PcepOpenMsg.class));
         ChannelBuffer buf = ChannelBuffers.dynamicBuffer();
         message.writeTo(buf);
         testOpenMsg = buf.array();
@@ -183,7 +183,7 @@
 
         message = reader.readFrom(buffer);
 
-        assertThat(message, sameInstance((PcepOpenMsg) message));
+        assertThat(message, instanceOf(PcepOpenMsg.class));
         ChannelBuffer buf = ChannelBuffers.dynamicBuffer();
         message.writeTo(buf);
         testOpenMsg = buf.array();
@@ -219,7 +219,7 @@
 
         message = reader.readFrom(buffer);
 
-        assertThat(message, sameInstance((PcepOpenMsg) message));
+        assertThat(message, instanceOf(PcepOpenMsg.class));
         ChannelBuffer buf = ChannelBuffers.dynamicBuffer();
         message.writeTo(buf);
         testOpenMsg = buf.array();
@@ -255,7 +255,7 @@
 
         message = reader.readFrom(buffer);
 
-        assertThat(message, sameInstance((PcepOpenMsg) message));
+        assertThat(message, instanceOf(PcepOpenMsg.class));
         ChannelBuffer buf = ChannelBuffers.dynamicBuffer();
         message.writeTo(buf);
         testOpenMsg = buf.array();
@@ -294,7 +294,7 @@
 
         message = reader.readFrom(buffer);
 
-        assertThat(message, sameInstance((PcepOpenMsg) message));
+        assertThat(message, instanceOf(PcepOpenMsg.class));
         ChannelBuffer buf = ChannelBuffers.dynamicBuffer();
         message.writeTo(buf);
         testOpenMsg = buf.array();
@@ -330,7 +330,7 @@
 
         message = reader.readFrom(buffer);
 
-        assertThat(message, sameInstance((PcepOpenMsg) message));
+        assertThat(message, instanceOf(PcepOpenMsg.class));
         ChannelBuffer buf = ChannelBuffers.dynamicBuffer();
         message.writeTo(buf);
         testOpenMsg = buf.array();
@@ -368,7 +368,7 @@
 
         message = reader.readFrom(buffer);
 
-        assertThat(message, sameInstance((PcepOpenMsg) message));
+        assertThat(message, instanceOf(PcepOpenMsg.class));
         ChannelBuffer buf = ChannelBuffers.dynamicBuffer();
         message.writeTo(buf);
         testOpenMsg = buf.array();
@@ -406,7 +406,7 @@
 
         message = reader.readFrom(buffer);
 
-        assertThat(message, sameInstance((PcepOpenMsg) message));
+        assertThat(message, instanceOf(PcepOpenMsg.class));
         ChannelBuffer buf = ChannelBuffers.dynamicBuffer();
         message.writeTo(buf);
         testOpenMsg = buf.array();
@@ -443,7 +443,7 @@
 
         message = reader.readFrom(buffer);
 
-        assertThat(message, sameInstance((PcepOpenMsg) message));
+        assertThat(message, instanceOf(PcepOpenMsg.class));
         ChannelBuffer buf = ChannelBuffers.dynamicBuffer();
         message.writeTo(buf);
         testOpenMsg = buf.array();
@@ -479,7 +479,7 @@
 
         message = reader.readFrom(buffer);
 
-        assertThat(message, sameInstance((PcepOpenMsg) message));
+        assertThat(message, instanceOf(PcepOpenMsg.class));
         ChannelBuffer buf = ChannelBuffers.dynamicBuffer();
         message.writeTo(buf);
         testOpenMsg = buf.array();
@@ -514,7 +514,7 @@
 
         message = reader.readFrom(buffer);
 
-        assertThat(message, sameInstance((PcepOpenMsg) message));
+        assertThat(message, instanceOf(PcepOpenMsg.class));
         ChannelBuffer buf = ChannelBuffers.dynamicBuffer();
         message.writeTo(buf);
         testOpenMsg = buf.array();
@@ -547,7 +547,7 @@
 
         message = reader.readFrom(buffer);
 
-        assertThat(message, sameInstance((PcepOpenMsg) message));
+        assertThat(message, instanceOf(PcepOpenMsg.class));
 
         ChannelBuffer buf = ChannelBuffers.dynamicBuffer();
         message.writeTo(buf);