Started refactoring Intent Manager
Introduced IntentData and reworked APIs
Change-Id: I1fa437ceb1b72c4017ac2da1573bfbeb64c0632a
diff --git a/core/net/src/main/java/org/onosproject/net/intent/impl/IntentAccumulator.java b/core/net/src/main/java/org/onosproject/net/intent/impl/IntentAccumulator.java
new file mode 100644
index 0000000..bc7a7f5
--- /dev/null
+++ b/core/net/src/main/java/org/onosproject/net/intent/impl/IntentAccumulator.java
@@ -0,0 +1,62 @@
+/*
+ * Copyright 2015 Open Networking Laboratory
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.onosproject.net.intent.impl;
+
+import com.google.common.collect.Maps;
+import org.onlab.util.AbstractAccumulator;
+import org.onosproject.net.intent.IntentData;
+
+import java.util.List;
+import java.util.Map;
+import java.util.Timer;
+
+/**
+ * An accumulator for building batches of intent operations. Only one batch should
+ * be in process per instance at a time.
+ */
+public class IntentAccumulator extends AbstractAccumulator<IntentData> {
+
+ private static final int DEFAULT_MAX_EVENTS = 1000;
+ private static final int DEFAULT_MAX_IDLE_MS = 10;
+ private static final int DEFAULT_MAX_BATCH_MS = 50;
+
+ // FIXME: Replace with a system-wide timer instance;
+ // TODO: Convert to use HashedWheelTimer or produce a variant of that; then decide which we want to adopt
+ private static final Timer TIMER = new Timer("intent-op-batching");
+
+ /**
+ * Creates an intent operation accumulator.
+ */
+ protected IntentAccumulator() {
+ super(TIMER, DEFAULT_MAX_EVENTS, DEFAULT_MAX_BATCH_MS, DEFAULT_MAX_IDLE_MS);
+ }
+
+ @Override
+ public void processEvents(List<IntentData> ops) {
+ Map<String, IntentData> opMap = reduce(ops);
+ // FIXME kick off the work
+ //for (IntentData data : opMap.values()) {}
+ }
+
+ private Map<String, IntentData> reduce(List<IntentData> ops) {
+ Map<String, IntentData> map = Maps.newHashMap();
+ for (IntentData op : ops) {
+ map.put(op.key(), op);
+ }
+ //TODO check the version... or maybe store will handle this.
+ return map;
+ }
+}
diff --git a/core/net/src/main/java/org/onosproject/net/intent/impl/IntentManager.java b/core/net/src/main/java/org/onosproject/net/intent/impl/IntentManager.java
index 685fa70..f94424f 100644
--- a/core/net/src/main/java/org/onosproject/net/intent/impl/IntentManager.java
+++ b/core/net/src/main/java/org/onosproject/net/intent/impl/IntentManager.java
@@ -37,6 +37,7 @@
import org.onosproject.net.intent.IntentBatchDelegate;
import org.onosproject.net.intent.IntentBatchService;
import org.onosproject.net.intent.IntentCompiler;
+import org.onosproject.net.intent.IntentData;
import org.onosproject.net.intent.IntentEvent;
import org.onosproject.net.intent.IntentException;
import org.onosproject.net.intent.IntentExtensionService;
@@ -128,6 +129,8 @@
private final IntentBatchDelegate batchDelegate = new InternalBatchDelegate();
private IdGenerator idGenerator;
+ private final IntentAccumulator accumulator = new IntentAccumulator();
+
@Activate
public void activate() {
store.setDelegate(delegate);
@@ -154,32 +157,41 @@
@Override
public void submit(Intent intent) {
checkNotNull(intent, INTENT_NULL);
- execute(IntentOperations.builder(intent.appId())
- .addSubmitOperation(intent).build());
+ IntentData data = new IntentData(intent, IntentState.INSTALL_REQ, null);
+ //FIXME timestamp?
+ store.addPending(data);
}
@Override
public void withdraw(Intent intent) {
checkNotNull(intent, INTENT_NULL);
- execute(IntentOperations.builder(intent.appId())
- .addWithdrawOperation(intent.id()).build());
+ IntentData data = new IntentData(intent, IntentState.WITHDRAW_REQ, null);
+ //FIXME timestamp?
+ store.addPending(data);
}
@Override
public void replace(IntentId oldIntentId, Intent newIntent) {
- checkNotNull(oldIntentId, INTENT_ID_NULL);
- checkNotNull(newIntent, INTENT_NULL);
- execute(IntentOperations.builder(newIntent.appId())
- .addReplaceOperation(oldIntentId, newIntent)
- .build());
+ throw new UnsupportedOperationException("replace is not implemented");
}
@Override
public void execute(IntentOperations operations) {
- if (operations.operations().isEmpty()) {
- return;
+ for (IntentOperation op : operations.operations()) {
+ switch (op.type()) {
+ case SUBMIT:
+ case UPDATE:
+ submit(op.intent());
+ break;
+ case WITHDRAW:
+ withdraw(op.intent());
+ break;
+ //fallthrough
+ case REPLACE:
+ default:
+ throw new UnsupportedOperationException("replace not supported");
+ }
}
- batchService.addIntentOperations(operations);
}
@Override
@@ -382,8 +394,8 @@
}
@Override
- public void process(IntentOperation op) {
- //FIXME
+ public void process(IntentData data) {
+ accumulator.add(data);
}
}
@@ -488,6 +500,7 @@
}
}
+ // TODO pull out the IntentUpdate inner classes
private class InstallRequest implements IntentUpdate {
private final Intent intent;