Sonar fixes
Rule: Use isEmpty() to check whether the collection is empty or not.
Change-Id: Ib5ab56b2263623b297db56c5cac2c2ee80e12725
diff --git a/apps/vtn/vtnmgr/src/main/java/org/onosproject/vtn/table/impl/L2ForwardServiceImpl.java b/apps/vtn/vtnmgr/src/main/java/org/onosproject/vtn/table/impl/L2ForwardServiceImpl.java
index 7c9c30d..582aad3 100644
--- a/apps/vtn/vtnmgr/src/main/java/org/onosproject/vtn/table/impl/L2ForwardServiceImpl.java
+++ b/apps/vtn/vtnmgr/src/main/java/org/onosproject/vtn/table/impl/L2ForwardServiceImpl.java
@@ -142,7 +142,7 @@
.withSelector(selector).fromApp(appId).makePermanent()
.withFlag(Flag.SPECIFIC).withPriority(MAC_PRIORITY);
if (type.equals(Objective.Operation.ADD)) {
- if (Sets.newHashSet(localVmPorts).size() == 0) {
+ if (Sets.newHashSet(localVmPorts).isEmpty()) {
flowObjectiveService.forward(deviceId, objective.remove());
} else {
flowObjectiveService.forward(deviceId, objective.add());
diff --git a/apps/vtn/vtnmgr/src/main/java/org/onosproject/vtn/util/VtnData.java b/apps/vtn/vtnmgr/src/main/java/org/onosproject/vtn/util/VtnData.java
index 2ee889a..c66cba6 100644
--- a/apps/vtn/vtnmgr/src/main/java/org/onosproject/vtn/util/VtnData.java
+++ b/apps/vtn/vtnmgr/src/main/java/org/onosproject/vtn/util/VtnData.java
@@ -137,7 +137,7 @@
}
}
});
- if (vPorts.size() == 0) {
+ if (vPorts.isEmpty()) {
return null;
}
return vPorts.get(0);
@@ -168,7 +168,7 @@
}
}
});
- if (vPorts.size() == 0) {
+ if (vPorts.isEmpty()) {
return null;
}
return vPorts.get(0);
diff --git a/apps/vtn/vtnrsc/src/main/java/org/onosproject/vtnrsc/virtualport/impl/VirtualPortManager.java b/apps/vtn/vtnrsc/src/main/java/org/onosproject/vtnrsc/virtualport/impl/VirtualPortManager.java
index ede595f..0b7d0a6 100644
--- a/apps/vtn/vtnrsc/src/main/java/org/onosproject/vtnrsc/virtualport/impl/VirtualPortManager.java
+++ b/apps/vtn/vtnrsc/src/main/java/org/onosproject/vtnrsc/virtualport/impl/VirtualPortManager.java
@@ -181,7 +181,7 @@
}
}
});
- if (vPorts.size() == 0) {
+ if (vPorts.isEmpty()) {
return null;
}
return vPorts.get(0);
@@ -196,7 +196,7 @@
vPorts.add(p);
}
});
- if (vPorts.size() == 0) {
+ if (vPorts.isEmpty()) {
return null;
}
return vPorts.get(0);
@@ -217,7 +217,7 @@
}
}
});
- if (vPorts.size() == 0) {
+ if (vPorts.isEmpty()) {
return null;
}
return vPorts.get(0);
diff --git a/apps/vtn/vtnweb/src/main/java/org/onosproject/vtnweb/resources/FloatingIpWebResource.java b/apps/vtn/vtnweb/src/main/java/org/onosproject/vtnweb/resources/FloatingIpWebResource.java
index c2c4632..8691b42 100644
--- a/apps/vtn/vtnweb/src/main/java/org/onosproject/vtnweb/resources/FloatingIpWebResource.java
+++ b/apps/vtn/vtnweb/src/main/java/org/onosproject/vtnweb/resources/FloatingIpWebResource.java
@@ -99,7 +99,7 @@
.getFloatingIp(FloatingIpId.of(id)), GET_FAIL);
ObjectNode result = new ObjectMapper().createObjectNode();
- if (fields.size() > 0) {
+ if (!fields.isEmpty()) {
result.set("floatingip",
new FloatingIpCodec().extracFields(sub, this, fields));
} else {
diff --git a/apps/vtn/vtnweb/src/main/java/org/onosproject/vtnweb/resources/RouterWebResource.java b/apps/vtn/vtnweb/src/main/java/org/onosproject/vtnweb/resources/RouterWebResource.java
index 855209c..332bd41 100644
--- a/apps/vtn/vtnweb/src/main/java/org/onosproject/vtnweb/resources/RouterWebResource.java
+++ b/apps/vtn/vtnweb/src/main/java/org/onosproject/vtnweb/resources/RouterWebResource.java
@@ -106,7 +106,7 @@
.getRouter(RouterId.valueOf(id)), NOT_EXIST);
ObjectNode result = new ObjectMapper().createObjectNode();
- if (fields.size() > 0) {
+ if (!fields.isEmpty()) {
result.set("router",
new RouterCodec().extracFields(sub, this, fields));
} else {