Add type code into LispType enum to prevent arbitrary place holder
With the existing implementation, if we want to specify type value
8 to ECM Lisp type, we need to generate several place holders
inside LispType enumerator, otherwise ECM will be assigned a
subsequent number which is 5.
With this commit, we can specify arbitrary number for each Lisp
enum type, therefore, no need to add redundant placeholder for
the purpose of incrementing enum value.
Change-Id: I82a82a3f5bc313dc1f79aaa66a77889408e8c891
diff --git a/protocols/lisp/msg/src/main/java/org/onosproject/lisp/msg/protocols/DefaultLispMapReply.java b/protocols/lisp/msg/src/main/java/org/onosproject/lisp/msg/protocols/DefaultLispMapReply.java
index b412cdb..59775f4 100644
--- a/protocols/lisp/msg/src/main/java/org/onosproject/lisp/msg/protocols/DefaultLispMapReply.java
+++ b/protocols/lisp/msg/src/main/java/org/onosproject/lisp/msg/protocols/DefaultLispMapReply.java
@@ -242,7 +242,6 @@
*/
public static final class ReplyWriter implements LispMessageWriter<LispMapReply> {
- private static final int REPLY_MSG_TYPE = 2;
private static final int REPLY_SHIFT_BIT = 4;
private static final int PROBE_FLAG_SHIFT_BIT = 3;
@@ -258,7 +257,7 @@
public void writeTo(ByteBuf byteBuf, LispMapReply message) throws LispWriterException {
// specify LISP message type
- byte msgType = (byte) (REPLY_MSG_TYPE << REPLY_SHIFT_BIT);
+ byte msgType = (byte) (LispType.LISP_MAP_REPLY.getTypeCode() << REPLY_SHIFT_BIT);
// probe flag
byte probe = DISABLE_BIT;