Added javadocs and simplified the reactive fwd app in attempt to find the glitch; no dice
diff --git a/core/trivial/src/main/java/org/onlab/onos/net/trivial/packet/impl/SimplePacketManager.java b/core/trivial/src/main/java/org/onlab/onos/net/trivial/packet/impl/SimplePacketManager.java
index 637ada8..53c3fbc 100644
--- a/core/trivial/src/main/java/org/onlab/onos/net/trivial/packet/impl/SimplePacketManager.java
+++ b/core/trivial/src/main/java/org/onlab/onos/net/trivial/packet/impl/SimplePacketManager.java
@@ -25,10 +25,8 @@
import org.onlab.onos.net.provider.AbstractProviderService;
import org.slf4j.Logger;
-
/**
* Provides a basic implementation of the packet SB & NB APIs.
- *
*/
@Component(immediate = true)
@Service
@@ -43,7 +41,6 @@
private final Map<Integer, PacketProcessor> processors = new TreeMap<>();
-
@Activate
public void activate() {
log.info("Started");
@@ -62,19 +59,20 @@
@Override
public void removeProcessor(PacketProcessor processor) {
+ checkNotNull(processor, "Processor cannot be null");
processors.values().remove(processor);
}
@Override
public void emit(OutboundPacket packet) {
+ checkNotNull(packet, "Packet cannot be null");
final Device device = deviceService.getDevice(packet.sendThrough());
final PacketProvider packetProvider = getProvider(device.providerId());
packetProvider.emit(packet);
}
@Override
- protected PacketProviderService createProviderService(
- PacketProvider provider) {
+ protected PacketProviderService createProviderService(PacketProvider provider) {
return new InternalPacketProviderService(provider);
}