Explicitly return NO CONTENT type response for http DELETE request
Change-Id: I920084b92197bb1687e7d978ad350b2e1290ecbc
diff --git a/apps/virtualbng/src/main/java/org/onosproject/virtualbng/VbngResource.java b/apps/virtualbng/src/main/java/org/onosproject/virtualbng/VbngResource.java
index 9f42191..72f2d3d 100644
--- a/apps/virtualbng/src/main/java/org/onosproject/virtualbng/VbngResource.java
+++ b/apps/virtualbng/src/main/java/org/onosproject/virtualbng/VbngResource.java
@@ -89,15 +89,16 @@
* Delete a virtual BNG connection.
*
* @param privateIp IP Address for the BNG private network
- * @return public IP address for the new connection
+ * @return 200 OK
*/
@DELETE
@Path("{privateip}")
- public String privateIpDeleteNotification(@PathParam("privateip")
+ public Response privateIpDeleteNotification(@PathParam("privateip")
String privateIp) {
+ String result;
if (privateIp == null) {
log.info("Private IP address to delete is null");
- return "0";
+ result = "0";
}
log.info("Received a private IP address : {} to delete", privateIp);
IpAddress privateIpAddress = IpAddress.valueOf(privateIp);
@@ -109,10 +110,11 @@
assignedPublicIpAddress = vbngService.deleteVbng(privateIpAddress);
if (assignedPublicIpAddress != null) {
- return assignedPublicIpAddress.toString();
+ result = assignedPublicIpAddress.toString();
} else {
- return "0";
+ result = "0";
}
+ return Response.ok().entity(result).build();
}
/**