Fix checkstyle errors when building archetype-generated apps

Checkstyle validation is now enabled by default in onos-dependencies
(archetypes' parent pom). We also add a reference to the archetypes' pom
to disable checkstyle, if needed.

Change-Id: I9b6e6cecf2d704f52ec1f118eae2aafd03cf0b9a
diff --git a/tools/test/bin/onos-archetypes-test b/tools/test/bin/onos-archetypes-test
index 5056477..33e3d4b 100755
--- a/tools/test/bin/onos-archetypes-test
+++ b/tools/test/bin/onos-archetypes-test
@@ -21,15 +21,17 @@
 export AROOT=${ONOS_STAGE_ROOT:-/tmp}/foo
 export ARCHETYPE_OPTS="-DarchetypeGroupId=org.onosproject -DarchetypeVersion=2.4.0-SNAPSHOT"
 
+rm -fr $AROOT 2>/dev/null
 mkdir -p $AROOT
+
 # FIXME: for an in api bundle cli rest ui uitab uitopo ui2; do
 for an in api bundle cli rest ui uitab uitopo; do
     cd $AROOT
-    rm -fr $AROOT/foo-$an
+    [ $an = api ] && name=foo-api || name=foo-app
     mvn -q -B archetype:generate "$@" $ARCHETYPE_OPTS \
         -DarchetypeArtifactId=onos-$an-archetype \
-        -DgroupId=org.foo -DartifactId=foo-$an -Dversion=1.0 \
-        -Dpackage=org.foo.$an -DinteractiveMode=false
-    cd $AROOT/foo-$an
+        -DgroupId=org.foo -DartifactId=$name -Dversion=1.0 \
+        -Dpackage=org.foo.test -DinteractiveMode=false
+    cd $AROOT/$name
     mvn "$@" -q -B clean install
 done