commit bb825d73b9b022aaec4a4e3847534a0d9ea4b4f4
author Sho SHIMIZU <sshimizu@us.fujitsu.com> Thu Jun 11 10:56:32 2015 -0700
committer Gerrit Code Review <gerrit@onlab.us> Thu Jun 11 21:43:46 2015 +0000
tree 6474e5a7faf4efc991e0703b660218eec6d30176
parent 63d9f649b11fb7a12e6d0e767feb420c8f554eaf

Remove forEach() that introduces side-effect inherently

Change-Id: Idd9784d7a8a4064e31b02f65701bc599b2fb3dbf

web/api/src/main/java/org/onosproject/rest/resources/ConfigProvider.java

diff --git a/web/api/src/main/java/org/onosproject/rest/resources/ConfigProvider.java b/web/api/src/main/java/org/onosproject/rest/resources/ConfigProvider.java
index 44772bf..2716354 100644
--- a/web/api/src/main/java/org/onosproject/rest/resources/ConfigProvider.java
+++ b/web/api/src/main/java/org/onosproject/rest/resources/ConfigProvider.java
@@ -80,6 +80,7 @@
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.TimeUnit;
 import java.util.stream.Collectors;
+import java.util.stream.Stream;
 
 import static com.google.common.base.Preconditions.checkNotNull;
 import static org.onosproject.net.DeviceId.deviceId;
@@ -455,9 +456,10 @@
                 .filter(cp -> !existing.contains(cp))
                 .collect(Collectors.toSet());
 
-        List<PortDescription> newPorts = Lists.newArrayList();
-        ports.forEach(p -> newPorts.add(description(p)));
-        missing.forEach(cp -> newPorts.add(description(cp)));
+        List<PortDescription> newPorts = Stream.concat(
+                ports.stream().map(this::description),
+                missing.stream().map(this::description)
+        ).collect(Collectors.toList());
         deviceProviderService.updatePorts(device.id(), newPorts);
     }