SONAR suggestion - log exceptions, don't print stack traces
Change-Id: I4814a0662912706df005972d44c48a7db39ecd50
diff --git a/apps/netconf/client/src/main/java/org/onosproject/netconf/client/impl/NetconfActiveComponent.java b/apps/netconf/client/src/main/java/org/onosproject/netconf/client/impl/NetconfActiveComponent.java
index 92043d5..33b52a4 100644
--- a/apps/netconf/client/src/main/java/org/onosproject/netconf/client/impl/NetconfActiveComponent.java
+++ b/apps/netconf/client/src/main/java/org/onosproject/netconf/client/impl/NetconfActiveComponent.java
@@ -194,7 +194,7 @@
return netconfTranslator.editDeviceConfig(
deviceId, builder.build(), operationType);
} catch (IOException e) {
- e.printStackTrace();
+ log.debug("parseAndEdit()", e);
return false;
}
}
diff --git a/apps/netconf/client/src/main/java/org/onosproject/netconf/client/impl/NetconfTranslatorImpl.java b/apps/netconf/client/src/main/java/org/onosproject/netconf/client/impl/NetconfTranslatorImpl.java
index c563204..f663fd0 100644
--- a/apps/netconf/client/src/main/java/org/onosproject/netconf/client/impl/NetconfTranslatorImpl.java
+++ b/apps/netconf/client/src/main/java/org/onosproject/netconf/client/impl/NetconfTranslatorImpl.java
@@ -93,8 +93,8 @@
@Component(immediate = true)
public class NetconfTranslatorImpl implements NetconfTranslator {
- private final Logger log = LoggerFactory
- .getLogger(getClass());
+ private static final Logger log = LoggerFactory
+ .getLogger(NetconfTranslator.class);
private NodeId localNodeId;
@@ -354,7 +354,7 @@
try {
rIdBldr = rid.copyBuilder();
} catch (CloneNotSupportedException e) {
- e.printStackTrace();
+ log.debug("clone not supported", e);
}
} else {
rIdBldr.addBranchPointSchema("/", null);
diff --git a/apps/netconf/client/src/main/java/org/onosproject/netconf/client/impl/Utils.java b/apps/netconf/client/src/main/java/org/onosproject/netconf/client/impl/Utils.java
index cb8e89c..5e06420 100644
--- a/apps/netconf/client/src/main/java/org/onosproject/netconf/client/impl/Utils.java
+++ b/apps/netconf/client/src/main/java/org/onosproject/netconf/client/impl/Utils.java
@@ -108,7 +108,7 @@
try {
transformer = transformerFactory.newTransformer();
} catch (TransformerConfigurationException e) {
- e.printStackTrace();
+ return "";
}
// Need to omit the xml header and set indent to 4
@@ -122,7 +122,7 @@
try {
transformer.transform(xmlInput, xmlOutput);
} catch (TransformerException e) {
- e.printStackTrace();
+ return "";
}
}
return xmlOutput.getWriter().toString();