Fixed a bug when parsing configuration properties for ReactiveForwarding
by catching the appropriate exception.
Apparently, if a property is configured/enabled in file Foo.cfg, e.g.:
flowTimeout = 10
then the corresponding object/value in the Dictionary returned by
ComponentContext.getProperties()
has class type String.
However, if the property is commented-out, e.g.:
then the Dictionary still contains an entry for "flowTimeout", but
its class type is Integer.
Also, updated similar code elsewhere that was catching the generic
Exception with catching more specific exception(s).
Change-Id: I33ec348eb9efe3188e22cfc8cee2bb704948726d
diff --git a/apps/fwd/src/main/java/org/onosproject/fwd/ReactiveForwarding.java b/apps/fwd/src/main/java/org/onosproject/fwd/ReactiveForwarding.java
index dcb28f9..46d6446 100644
--- a/apps/fwd/src/main/java/org/onosproject/fwd/ReactiveForwarding.java
+++ b/apps/fwd/src/main/java/org/onosproject/fwd/ReactiveForwarding.java
@@ -305,7 +305,7 @@
try {
String s = (String) properties.get(propertyName);
value = isNullOrEmpty(s) ? value : Integer.parseInt(s.trim());
- } catch (NumberFormatException e) {
+ } catch (NumberFormatException | ClassCastException e) {
value = null;
}
return value;