Sonar suggestion - use a secure random number generator
Change-Id: I28075845555bcbc384a49e07353b3192c413b8f7
diff --git a/utils/misc/src/main/java/org/onlab/graph/GAPopulation.java b/utils/misc/src/main/java/org/onlab/graph/GAPopulation.java
index 22efd84..d85bd3b 100644
--- a/utils/misc/src/main/java/org/onlab/graph/GAPopulation.java
+++ b/utils/misc/src/main/java/org/onlab/graph/GAPopulation.java
@@ -15,6 +15,7 @@
*/
package org.onlab.graph;
+import java.security.SecureRandom;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
@@ -25,7 +26,7 @@
* to run a genetic algorithm on the population and return the fittest solutions.
*/
class GAPopulation<Organism extends GAOrganism> extends ArrayList<Organism> {
- Random r = new Random();
+ Random r = new SecureRandom();
/**
* Steps the population through one generation. The 75% least fit
diff --git a/utils/misc/src/main/java/org/onlab/graph/SrlgGraphSearch.java b/utils/misc/src/main/java/org/onlab/graph/SrlgGraphSearch.java
index d455c64..46a7cab 100644
--- a/utils/misc/src/main/java/org/onlab/graph/SrlgGraphSearch.java
+++ b/utils/misc/src/main/java/org/onlab/graph/SrlgGraphSearch.java
@@ -18,13 +18,13 @@
package org.onlab.graph;
+import java.security.SecureRandom;
import java.util.Map;
import java.util.List;
import java.util.HashMap;
import java.util.HashSet;
-import java.util.Set;
import java.util.Random;
-
+import java.util.Set;
/**
* SRLG Graph Search finds a pair of paths with disjoint risk groups; i.e
@@ -171,7 +171,7 @@
boolean[] subset;
boolean[] not;
- Random r = new Random();
+ Random r = new SecureRandom();
/**
* Creates a Subset from the given subset array.
diff --git a/utils/misc/src/main/java/org/onlab/util/Tools.java b/utils/misc/src/main/java/org/onlab/util/Tools.java
index a8c8a8b..0989010 100644
--- a/utils/misc/src/main/java/org/onlab/util/Tools.java
+++ b/utils/misc/src/main/java/org/onlab/util/Tools.java
@@ -32,6 +32,7 @@
import java.nio.file.SimpleFileVisitor;
import java.nio.file.StandardCopyOption;
import java.nio.file.attribute.BasicFileAttributes;
+import java.security.SecureRandom;
import java.time.Instant;
import java.time.OffsetDateTime;
import java.time.ZoneId;
@@ -72,7 +73,7 @@
private static final Logger log = getLogger(Tools.class);
- private static Random random = new Random();
+ private static Random random = new SecureRandom();
/**
* Returns a thread factory that produces threads named according to the