Sonar suggestion - use a secure random number generator
Change-Id: I28075845555bcbc384a49e07353b3192c413b8f7
diff --git a/apps/pim/src/main/java/org/onosproject/pim/impl/PimInterface.java b/apps/pim/src/main/java/org/onosproject/pim/impl/PimInterface.java
index b52acc5..8c2d8d3 100644
--- a/apps/pim/src/main/java/org/onosproject/pim/impl/PimInterface.java
+++ b/apps/pim/src/main/java/org/onosproject/pim/impl/PimInterface.java
@@ -28,20 +28,20 @@
import org.onlab.packet.pim.PIMHelloOption;
import org.onlab.packet.pim.PIMJoinPrune;
import org.onlab.packet.pim.PIMJoinPruneGroup;
-import org.onosproject.net.intf.Interface;
import org.onosproject.net.flow.DefaultTrafficTreatment;
import org.onosproject.net.flow.TrafficTreatment;
import org.onosproject.net.host.InterfaceIpAddress;
+import org.onosproject.net.intf.Interface;
import org.onosproject.net.mcast.McastRoute;
import org.onosproject.net.packet.DefaultOutboundPacket;
import org.onosproject.net.packet.PacketService;
import org.slf4j.Logger;
import java.nio.ByteBuffer;
+import java.security.SecureRandom;
import java.util.Collection;
import java.util.List;
import java.util.Map;
-import java.util.Random;
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.TimeUnit;
@@ -119,7 +119,7 @@
lastHello = 0;
- generationId = new Random().nextInt();
+ generationId = new SecureRandom().nextInt();
// Create a PIM Neighbor to represent ourselves for DR election.
PimNeighbor us = new PimNeighbor(ourIp, mac, holdTime, 0, priority, generationId);
diff --git a/apps/test/demo/src/main/java/org/onosproject/demo/DemoInstaller.java b/apps/test/demo/src/main/java/org/onosproject/demo/DemoInstaller.java
index 53dea1f..369a3af 100644
--- a/apps/test/demo/src/main/java/org/onosproject/demo/DemoInstaller.java
+++ b/apps/test/demo/src/main/java/org/onosproject/demo/DemoInstaller.java
@@ -15,6 +15,7 @@
*/
package org.onosproject.demo;
+import java.security.SecureRandom;
import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
@@ -278,7 +279,7 @@
private final boolean isLocal;
private final Set<Host> hosts;
- private final Random random = new Random(System.currentTimeMillis());
+ private final Random random = new SecureRandom();
private Set<HostPair> uninstalledOrWithdrawn;
private Set<HostPair> installed;