commit b5cd581d4e96a367427d5802d4c5e82c6320ae17
author Sho SHIMIZU <sshimizu@us.fujitsu.com> Mon Feb 09 14:25:13 2015 -0800
committer Brian O'Connor <bocon@onlab.us> Fri Feb 13 14:10:55 2015 -0800
tree 830a31b51e8e6832720d0318b2e822b8f4cc1fe4
parent 877ec2c51fe8ac336da682ca43adb21755ee54ef

Handle exception when installing fails

- Catch an IntentException in InstallCoordinating and Installing
- Remove FlowRuleBatchOperationConvertionException because it is unused

Change-Id: I99cf07df811ba8489feb75088f83ddc4ebd93c9e

core/net/src/main/java/org/onosproject/net/intent/impl/Installing.java

diff --git a/core/net/src/main/java/org/onosproject/net/intent/impl/Installing.java b/core/net/src/main/java/org/onosproject/net/intent/impl/Installing.java
index 205345c..122f224 100644
--- a/core/net/src/main/java/org/onosproject/net/intent/impl/Installing.java
+++ b/core/net/src/main/java/org/onosproject/net/intent/impl/Installing.java
@@ -17,6 +17,7 @@
 
 import org.onosproject.net.flow.FlowRuleOperations;
 import org.onosproject.net.intent.IntentData;
+import org.onosproject.net.intent.IntentException;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -48,8 +49,10 @@
         try {
             intentManager.flowRuleService.apply(flowRules); // FIXME we need to provide a context
             return Optional.of(new Installed(pending));
-        } catch (FlowRuleBatchOperationConversionException e) {
-            log.warn("Unable to install intent {} due to:", pending.intent().id(), e.getCause());
+        // What kinds of exceptions are thrown by FlowRuleService.apply()?
+        // Is IntentException a correct exception abstraction?
+        } catch (IntentException e) {
+            log.warn("Unable to install intent {} due to: {}", pending.intent().id(), e);
             return Optional.of(new InstallingFailed(pending));
         }
     }