Revert changes to use constants for Sonar suppression
It turns out that suppression annotations have to have the actual
string literal in them; if you use a defined constant SonarQube
ignores the suppression.
Change-Id: I3628df116d182b01a108da0d6f059784a3be4fed
diff --git a/core/net/src/main/java/org/onosproject/app/impl/ApplicationManager.java b/core/net/src/main/java/org/onosproject/app/impl/ApplicationManager.java
index 35555a1..a8609ac 100644
--- a/core/net/src/main/java/org/onosproject/app/impl/ApplicationManager.java
+++ b/core/net/src/main/java/org/onosproject/app/impl/ApplicationManager.java
@@ -44,7 +44,6 @@
import com.google.common.collect.Maps;
import static com.google.common.base.Preconditions.checkNotNull;
-import static org.onlab.util.SonarSuppressionConstants.SONAR_CALL_RUN;
import static org.onosproject.app.ApplicationEvent.Type.APP_ACTIVATED;
import static org.onosproject.app.ApplicationEvent.Type.APP_DEACTIVATED;
import static org.onosproject.app.ApplicationEvent.Type.APP_INSTALLED;
@@ -281,7 +280,7 @@
}
// Invokes the specified function, if not null.
- @java.lang.SuppressWarnings(SONAR_CALL_RUN) // We really do mean to call run()
+ @java.lang.SuppressWarnings("squid:S1217") // We really do mean to call run()
private void invokeHook(Runnable hook, ApplicationId appId) {
if (hook != null) {
try {