commit a7e60c65c8b67739e872d745c3fed4482ba791f1
author Carmelo Cascone <carmelo@opennetworking.org> Thu Mar 21 17:58:12 2019 -0700
committer Carmelo Cascone <carmelo@opennetworking.org> Sat Mar 23 01:04:10 2019 +0000
tree 5b2fe426e3a6f971a8e040752ead5e5357cb31fc
parent 70e816b05ad7a592178f85221149b1855bc4f9ed

Various fixes for P4Runtime group handling

- Workaround for PI bug that ignores max_group_size
- Use max_group_size and not buckets size when translating groups

Change-Id: Id12a12311b20ca8fb4e785e1c5a4f0f4215d1bbf

core/api/src/main/java/org/onosproject/net/pi/runtime/PiActionProfileGroup.java

diff --git a/core/api/src/main/java/org/onosproject/net/pi/runtime/PiActionProfileGroup.java b/core/api/src/main/java/org/onosproject/net/pi/runtime/PiActionProfileGroup.java
index 3fd7e08..f8036f5 100644
--- a/core/api/src/main/java/org/onosproject/net/pi/runtime/PiActionProfileGroup.java
+++ b/core/api/src/main/java/org/onosproject/net/pi/runtime/PiActionProfileGroup.java
@@ -111,7 +111,11 @@
         final PiActionProfileGroup other = (PiActionProfileGroup) obj;
         return Objects.equal(this.groupId, other.groupId)
                 && Objects.equal(this.members, other.members)
-                && Objects.equal(this.maxSize, other.maxSize)
+                // FIXME: re-enable when this PI bug will be fixed:
+                // https://github.com/p4lang/PI/issues/452
+                // Currently PI-based devices always return max_group_size 0,
+                // event if we set a different one.
+                // && Objects.equal(this.maxSize, other.maxSize)
                 && Objects.equal(this.actionProfileId, other.actionProfileId);
     }