Refactor k8s-node and k8s-networking command line interfaces
Change-Id: I1eb20ccea5238893a1c58e7faeb4c3a06accd2a9
diff --git a/apps/k8s-networking/app/src/main/java/org/onosproject/k8snetworking/cli/K8sPodListCommand.java b/apps/k8s-networking/app/src/main/java/org/onosproject/k8snetworking/cli/K8sPodListCommand.java
index 7845df1..c597b01 100644
--- a/apps/k8s-networking/app/src/main/java/org/onosproject/k8snetworking/cli/K8sPodListCommand.java
+++ b/apps/k8s-networking/app/src/main/java/org/onosproject/k8snetworking/cli/K8sPodListCommand.java
@@ -18,9 +18,11 @@
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.node.ArrayNode;
import com.fasterxml.jackson.databind.node.ObjectNode;
+import com.google.common.collect.ImmutableList;
import com.google.common.collect.Lists;
import io.fabric8.kubernetes.api.model.Pod;
import io.fabric8.kubernetes.client.utils.Serialization;
+import org.apache.commons.lang.StringUtils;
import org.apache.karaf.shell.api.action.Command;
import org.apache.karaf.shell.api.action.lifecycle.Service;
import org.onosproject.cli.AbstractShellCommand;
@@ -30,6 +32,12 @@
import java.util.Comparator;
import java.util.List;
+import static org.onosproject.k8snetworking.api.Constants.CLI_CONTAINERS_LENGTH;
+import static org.onosproject.k8snetworking.api.Constants.CLI_IP_ADDRESS_LENGTH;
+import static org.onosproject.k8snetworking.api.Constants.CLI_MARGIN_LENGTH;
+import static org.onosproject.k8snetworking.api.Constants.CLI_NAMESPACE_LENGTH;
+import static org.onosproject.k8snetworking.api.Constants.CLI_NAME_LENGTH;
+import static org.onosproject.k8snetworking.util.K8sNetworkingUtil.genFormatString;
import static org.onosproject.k8snetworking.util.K8sNetworkingUtil.prettyJson;
/**
@@ -40,18 +48,19 @@
description = "Lists all kubernetes pods")
public class K8sPodListCommand extends AbstractShellCommand {
- private static final String FORMAT = "%-50s%-15s%-15s%-30s";
-
@Override
protected void doExecute() {
K8sPodService service = get(K8sPodService.class);
List<Pod> pods = Lists.newArrayList(service.pods());
pods.sort(Comparator.comparing(p -> p.getMetadata().getName()));
+ String format = genFormatString(ImmutableList.of(CLI_NAME_LENGTH,
+ CLI_NAMESPACE_LENGTH, CLI_IP_ADDRESS_LENGTH, CLI_CONTAINERS_LENGTH));
+
if (outputJson()) {
print("%s", json(pods));
} else {
- print(FORMAT, "Name", "Namespace", "IP Address", "Containers");
+ print(format, "Name", "Namespace", "IP Address", "Containers");
for (Pod pod : pods) {
@@ -59,10 +68,13 @@
pod.getSpec().getContainers().forEach(c -> containers.add(c.getName()));
- print(FORMAT,
- pod.getMetadata().getName(),
- pod.getMetadata().getNamespace(),
- pod.getStatus().getPodIP(),
+ print(format,
+ StringUtils.substring(pod.getMetadata().getName(),
+ 0, CLI_NAME_LENGTH - CLI_MARGIN_LENGTH),
+ StringUtils.substring(pod.getMetadata().getNamespace(),
+ 0, CLI_NAMESPACE_LENGTH - CLI_MARGIN_LENGTH),
+ StringUtils.substring(pod.getStatus().getPodIP(),
+ 0, CLI_IP_ADDRESS_LENGTH - CLI_MARGIN_LENGTH),
containers.isEmpty() ? "" : containers);
}
}