Added a few todos.
diff --git a/core/api/src/main/java/org/onlab/onos/net/HostLocation.java b/core/api/src/main/java/org/onlab/onos/net/HostLocation.java
index 22673a6..626b027 100644
--- a/core/api/src/main/java/org/onlab/onos/net/HostLocation.java
+++ b/core/api/src/main/java/org/onlab/onos/net/HostLocation.java
@@ -1,13 +1,12 @@
package org.onlab.onos.net;
-import java.util.Objects;
-
/**
* Representation of a network edge location where an end-station host is
* connected.
*/
public class HostLocation extends ConnectPoint {
+ // Note that time is explicitly excluded from the notion of equality.
private final long time;
public HostLocation(DeviceId deviceId, PortNumber portNumber, long time) {
@@ -25,18 +24,4 @@
return time;
}
- @Override
- public int hashCode() {
- return 31 * super.hashCode() + Objects.hash(time);
- }
-
- @Override
- public boolean equals(Object obj) {
- if (obj instanceof HostLocation) {
- final HostLocation other = (HostLocation) obj;
- return super.equals(obj) && Objects.equals(this.time, other.time);
- }
- return false;
- }
-
}
diff --git a/core/api/src/main/java/org/onlab/onos/net/host/HostService.java b/core/api/src/main/java/org/onlab/onos/net/host/HostService.java
index 357fb61..a42e231 100644
--- a/core/api/src/main/java/org/onlab/onos/net/host/HostService.java
+++ b/core/api/src/main/java/org/onlab/onos/net/host/HostService.java
@@ -43,7 +43,6 @@
* @param vlanId vlan identifier
* @return set of hosts in the given vlan id
*/
- // FIXME: change long to VLanId
Set<Host> getHostsByVlan(VlanId vlanId);
/**
@@ -62,6 +61,8 @@
*/
Set<Host> getHostsByIp(IpAddress ip);
+ // TODO: consider adding Host getHostByIp(IpAddress ip, VlanId vlan);
+
/**
* Returns the set of hosts whose most recent location is the specified
* connection point.