[ONOS-3203] Remove final keyword from method arguements
Removing as requested by Thomas Vachuska so to be consistent with rest of ONOS code.
Note : ./tools/build/conf/src/main/resources/onos/pmd.xml deliberately excludes MethodArgumentCouldBeFinal from optimizations.xml
Change-Id: Ib1468d5ac39876797b79bd1f6dabd779bfe337bd
diff --git a/apps/faultmanagement/fmweb/src/test/java/org/onosproject/faultmanagement/web/AlarmCodecTest.java b/apps/faultmanagement/fmweb/src/test/java/org/onosproject/faultmanagement/web/AlarmCodecTest.java
index 3009b99a..012b1ff 100644
--- a/apps/faultmanagement/fmweb/src/test/java/org/onosproject/faultmanagement/web/AlarmCodecTest.java
+++ b/apps/faultmanagement/fmweb/src/test/java/org/onosproject/faultmanagement/web/AlarmCodecTest.java
@@ -107,7 +107,7 @@
}
- private void assertCommon(final Alarm alarm) {
+ private void assertCommon(Alarm alarm) {
assertThat(alarm.id(), is(new AlarmId(10L)));
assertThat(alarm.description(), is("NE is not reachable"));
assertThat(alarm.source(), is(AlarmEntityId.NONE));
@@ -124,9 +124,9 @@
*
* @param resourceName resource to use to read the JSON for the rule
* @return decoded flow rule
- * @throws IOException if processing the resource failsdecode
+ * @throws IOException if processing the resource fails to decode
*/
- private Alarm getDecodedAlarm(final JsonCodec<Alarm> codec, final String resourceName) throws IOException {
+ private Alarm getDecodedAlarm(JsonCodec<Alarm> codec, String resourceName) throws IOException {
final InputStream jsonStream = AlarmCodecTest.class
.getResourceAsStream(resourceName);
final JsonNode json = context.mapper().readTree(jsonStream);
diff --git a/apps/faultmanagement/fmweb/src/test/java/org/onosproject/faultmanagement/web/AlarmJsonMatcher.java b/apps/faultmanagement/fmweb/src/test/java/org/onosproject/faultmanagement/web/AlarmJsonMatcher.java
index 14bb45f..9a295c8 100644
--- a/apps/faultmanagement/fmweb/src/test/java/org/onosproject/faultmanagement/web/AlarmJsonMatcher.java
+++ b/apps/faultmanagement/fmweb/src/test/java/org/onosproject/faultmanagement/web/AlarmJsonMatcher.java
@@ -28,12 +28,12 @@
private final Alarm alarm;
- private AlarmJsonMatcher(final Alarm alarm) {
+ private AlarmJsonMatcher(Alarm alarm) {
this.alarm = alarm;
}
@Override
- public boolean matchesSafely(final JsonNode jsonAlarm, final Description description) {
+ public boolean matchesSafely(JsonNode jsonAlarm, Description description) {
final String jsonAlarmId = jsonAlarm.get("id").asText();
final String alarmId = Long.toString(alarm.id().fingerprint());
if (!jsonAlarmId.equals(alarmId)) {
@@ -119,7 +119,7 @@
}
@Override
- public void describeTo(final Description description) {
+ public void describeTo(Description description) {
description.appendText(alarm.toString());
}
@@ -129,7 +129,7 @@
* @param alarm alarm object we are looking for
* @return matcher
*/
- public static AlarmJsonMatcher matchesAlarm(final Alarm alarm) {
+ public static AlarmJsonMatcher matchesAlarm(Alarm alarm) {
return new AlarmJsonMatcher(alarm);
}
}
diff --git a/apps/faultmanagement/fmweb/src/test/java/org/onosproject/faultmanagement/web/AlarmsWebResourceTest.java b/apps/faultmanagement/fmweb/src/test/java/org/onosproject/faultmanagement/web/AlarmsWebResourceTest.java
index 0b7d981..e07487c 100644
--- a/apps/faultmanagement/fmweb/src/test/java/org/onosproject/faultmanagement/web/AlarmsWebResourceTest.java
+++ b/apps/faultmanagement/fmweb/src/test/java/org/onosproject/faultmanagement/web/AlarmsWebResourceTest.java
@@ -41,8 +41,7 @@
final CodecManager codecService = new CodecManager();
codecService.activate();
- final ServiceDirectory testDirectory
- = new TestServiceDirectory()
+ final ServiceDirectory testDirectory = new TestServiceDirectory()
// Currently no alarms-service implemented
// .add(AlarmsService.class, alarmsService)
.add(CodecService.class, codecService);