commit a4d40f37bfd342c64595fea6c7357d303dd55870
author David Glantz <david.glantz@windstream.com> Tue Sep 21 11:21:36 2021 -0500
committer Pier Luigi Ventre <pier@opennetworking.org> Thu Sep 30 17:04:37 2021 +0000
tree fd1d19f8404261f222c264858775c22f0fd30813
parent e3c605e3cf137532af81f51f435cc5f2d81cedf5

Remove logic to create a link when network configuration is added.

Change-Id: I9e26308c0f5ce9c5b70ccdbc37d97e4f480ff227

core/net/src/main/java/org/onosproject/net/link/impl/LinkManager.java

diff --git a/core/net/src/main/java/org/onosproject/net/link/impl/LinkManager.java b/core/net/src/main/java/org/onosproject/net/link/impl/LinkManager.java
index 326020b..ef09ee7 100644
--- a/core/net/src/main/java/org/onosproject/net/link/impl/LinkManager.java
+++ b/core/net/src/main/java/org/onosproject/net/link/impl/LinkManager.java
@@ -370,20 +370,14 @@
             Link link = getLink(src, dst);
             LinkDescription desc;
 
-            if (link == null) {
-                // TODO Revisit this behaviour.
-                // config alone probably should not be adding a link,
-                // netcfg provider should be the one.
-                desc = BasicLinkOperator.descriptionOf(src, dst, cfg);
-            } else {
+            if (link != null) {
                 desc = BasicLinkOperator.combine(cfg,
                         BasicLinkOperator.descriptionOf(src, dst, link));
+                ProviderId pid = Optional.ofNullable(link)
+                        .map(Link::providerId)
+                        .orElse(ProviderId.NONE);
+                store.createOrUpdateLink(pid, desc);
             }
-
-            ProviderId pid = Optional.ofNullable(link)
-                    .map(Link::providerId)
-                    .orElse(ProviderId.NONE);
-            store.createOrUpdateLink(pid, desc);
         }
     }
 }