commit a3ffbdbe9f067f49061d835d8b1041597d259536
author Daniel Park <dan.mcpark84@gmail.com> Wed Nov 28 13:51:39 2018 +0900
committer Jian Li <pyguni@gmail.com> Wed Nov 28 12:17:48 2018 +0000
tree 769035d331290adac89fcf74e82931db3e2aeec7
parent a5b942d4d04af3881ade2dc8e7cf6288f63dc3a0

Resolves code smells of OpenstackNetworkingUtil, RulePopulatorUtil and cli classes.

Change-Id: Id313b66f1b5303cea17477f3763496b405f08b87

apps/openstacknetworking/app/src/main/java/org/onosproject/openstacknetworking/util/RulePopulatorUtil.java

diff --git a/apps/openstacknetworking/app/src/main/java/org/onosproject/openstacknetworking/util/RulePopulatorUtil.java b/apps/openstacknetworking/app/src/main/java/org/onosproject/openstacknetworking/util/RulePopulatorUtil.java
index 1f6c1eb..0466e3b 100644
--- a/apps/openstacknetworking/app/src/main/java/org/onosproject/openstacknetworking/util/RulePopulatorUtil.java
+++ b/apps/openstacknetworking/app/src/main/java/org/onosproject/openstacknetworking/util/RulePopulatorUtil.java
@@ -48,7 +48,6 @@
     private static final String CT_FLAGS = "flags";
     private static final String CT_ZONE = "zone";
     private static final String CT_TABLE = "recircTable";
-    private static final String CT = "niciraCt";
     private static final String CT_STATE = "ctState";
     private static final String CT_STATE_MASK = "ctStateMask";
     private static final String CT_PRESENT_FLAGS = "presentFlags";
@@ -108,7 +107,7 @@
             treatment.setPropertyValue(TUNNEL_DST, remoteIp);
             return treatment;
         } catch (ExtensionPropertyException e) {
-            log.warn("Failed to get tunnelDst extension treatment for {}", deviceId);
+            log.warn("Failed to get tunnelDst extension treatment for {} because of {}", deviceId, e);
             return null;
         }
     }
@@ -133,7 +132,7 @@
             extensionSelector.setPropertyValue(CT_STATE, ctState);
             extensionSelector.setPropertyValue(CT_STATE_MASK, ctSateMask);
         } catch (Exception e) {
-            log.error("Failed to set nicira match CT state");
+            log.error("Failed to set nicira match CT state because of {}", e);
             return null;
         }
 
@@ -292,7 +291,7 @@
                     natTreatment.setPropertyValue(CT_PRESENT_FLAGS, 0);
                 }
             } catch (Exception e) {
-                log.error("Failed to set NAT due to error : {}", e.getMessage());
+                log.error("Failed to set NAT due to error : {}", e);
                 return null;
             }
 
@@ -308,7 +307,7 @@
                 ctTreatment.setPropertyValue(CT_TABLE, table > -1 ? table : 0xff);
                 ctTreatment.setPropertyValue("nestedActions", nat);
             } catch (Exception e) {
-                log.error("Failed to set CT due to error : {}", e.getMessage());
+                log.error("Failed to set CT due to error : {}", e);
                 return null;
             }