commit a3fcf6754a23a46f2c7b7f856817ea8b4fc5cfb1
author Jon Hall <jhall@ciena.com> Tue Mar 28 16:53:22 2017 -0700
committer Ray Milkey <ray@onlab.us> Wed Apr 05 22:54:30 2017 +0000
tree 2508a2f4bcff7c24cd4d9bcac29aa4e13bad48cd
parent 634eb17ac5e522b94632e34fa797a8333f321892

Fix Sonar issue:

Strings literals should be placed on the left side when checking for
equality

Change-Id: I4537e08936731ace55aeecb3ad941269ec1eb191

drivers/utilities/src/main/java/org/onosproject/drivers/utilities/YangXmlUtils.java

diff --git a/drivers/utilities/src/main/java/org/onosproject/drivers/utilities/YangXmlUtils.java b/drivers/utilities/src/main/java/org/onosproject/drivers/utilities/YangXmlUtils.java
index c1e8771..62a2c57 100644
--- a/drivers/utilities/src/main/java/org/onosproject/drivers/utilities/YangXmlUtils.java
+++ b/drivers/utilities/src/main/java/org/onosproject/drivers/utilities/YangXmlUtils.java
@@ -131,7 +131,7 @@
     private void addProperties(HierarchicalConfiguration cfg, HierarchicalConfiguration complete) {
         cfg.getKeys().forEachRemaining(key -> {
             String property = (String) cfg.getProperty(key);
-            if (!property.equals("")) {
+            if (!"".equals(property)) {
                 complete.setProperty(key, property);
             }
         });

drivers/utilities/src/test/java/org/onosproject/drivers/utilities/XmlConfigParserTest.java

diff --git a/drivers/utilities/src/test/java/org/onosproject/drivers/utilities/XmlConfigParserTest.java b/drivers/utilities/src/test/java/org/onosproject/drivers/utilities/XmlConfigParserTest.java
index d344a5c..044a15a 100644
--- a/drivers/utilities/src/test/java/org/onosproject/drivers/utilities/XmlConfigParserTest.java
+++ b/drivers/utilities/src/test/java/org/onosproject/drivers/utilities/XmlConfigParserTest.java
@@ -51,7 +51,7 @@
         InputStream stream = getClass().getResourceAsStream("/testConfig.xml");
         String switchId = XmlConfigParser.parseSwitchId(XmlConfigParser
                                                                 .loadXml(stream));
-        assertTrue(switchId.equals("ofc-bridge"));
+        assertTrue("ofc-bridge".equals(switchId));
     }
 
     @Test
@@ -59,7 +59,7 @@
         InputStream stream = getClass().getResourceAsStream("/testConfig.xml");
         String capableSwitchId = XmlConfigParser
                 .parseCapableSwitchId(XmlConfigParser.loadXml(stream));
-        assertTrue(capableSwitchId.equals("openvswitch"));
+        assertTrue("openvswitch".equals(capableSwitchId));
     }
 
     @Test