commit 9faab75be09f4edaf6652de42cbd6c0ea08a19ef
author Zsolt Haraszti <zharaszt@ciena.com> Wed Feb 17 15:55:20 2016 -0800
committer Gerrit Code Review <gerrit@onlab.us> Thu Feb 18 09:03:42 2016 +0000
tree 7f879c21afd2dc420f871e632dbf49db5b4d8050
parent a04483cd3d326d3d1a6bb283eba8d478047ca5a5

Add missing fail() invocation

Added missing fail() call-out in the versatile flow objective handler in
OFDPA2Pipeline.java to cover the case when neither a nextId nor a
treatment is provided.

Change-Id: Ic73e614c141281ff0014a8055d35183b7c3abd4e

drivers/default/src/main/java/org/onosproject/driver/pipeline/OFDPA2Pipeline.java

diff --git a/drivers/default/src/main/java/org/onosproject/driver/pipeline/OFDPA2Pipeline.java b/drivers/default/src/main/java/org/onosproject/driver/pipeline/OFDPA2Pipeline.java
index 2f58bfb..9f52ac0 100644
--- a/drivers/default/src/main/java/org/onosproject/driver/pipeline/OFDPA2Pipeline.java
+++ b/drivers/default/src/main/java/org/onosproject/driver/pipeline/OFDPA2Pipeline.java
@@ -645,6 +645,7 @@
         if (fwd.nextId() == null && fwd.treatment() == null) {
             log.error("Forwarding objective {} from {} must contain "
                     + "nextId or Treatment", fwd.selector(), fwd.appId());
+            fail(fwd, ObjectiveError.BADPARAMS);
             return Collections.emptySet();
         }