commit 9dc5739c3fb64b22074caf3cdd1039ad7ea56770
author Ray Milkey <ray@opennetworking.org> Fri Jun 08 08:52:31 2018 -0700
committer Ray Milkey <ray@opennetworking.org> Mon Jun 11 04:42:00 2018 +0000
tree 5f02c9ae601f06cb6dc3c06c4262e6b2a4511e6b
parent 4dda81402d3efcf2ad6472bb019350e13c509cdd

Sonar suggestion - Don't use a mutable collection in a public interface

Change-Id: I6f73f665cff20e558a8ec2f3cd319e4d9b00bb58

apps/openstacknetworking/app/src/main/java/org/onosproject/openstacknetworking/impl/OpenstackSwitchingHostProvider.java

diff --git a/apps/openstacknetworking/app/src/main/java/org/onosproject/openstacknetworking/impl/OpenstackSwitchingHostProvider.java b/apps/openstacknetworking/app/src/main/java/org/onosproject/openstacknetworking/impl/OpenstackSwitchingHostProvider.java
index e7492bf..62fd2b4 100644
--- a/apps/openstacknetworking/app/src/main/java/org/onosproject/openstacknetworking/impl/OpenstackSwitchingHostProvider.java
+++ b/apps/openstacknetworking/app/src/main/java/org/onosproject/openstacknetworking/impl/OpenstackSwitchingHostProvider.java
@@ -64,7 +64,7 @@
 import static org.onlab.util.Tools.groupedThreads;
 import static org.onosproject.net.AnnotationKeys.PORT_NAME;
 import static org.onosproject.openstacknetworking.api.Constants.OPENSTACK_NETWORKING_APP_ID;
-import static org.onosproject.openstacknetworking.api.Constants.PORT_NAME_PREFIX_MAP;
+import static org.onosproject.openstacknetworking.api.Constants.portNamePrefixMap;
 import static org.onosproject.openstacknetworking.impl.HostBasedInstancePort.ANNOTATION_CREATE_TIME;
 import static org.onosproject.openstacknetworking.impl.HostBasedInstancePort.ANNOTATION_NETWORK_ID;
 import static org.onosproject.openstacknetworking.impl.HostBasedInstancePort.ANNOTATION_PORT_ID;
@@ -236,7 +236,7 @@
         }
 
         private boolean isDirectPort(String portName) {
-            return PORT_NAME_PREFIX_MAP.values().stream().filter(p -> portName.startsWith(p)).findAny().isPresent();
+            return portNamePrefixMap().values().stream().filter(p -> portName.startsWith(p)).findAny().isPresent();
         }
 
         @Override
@@ -346,7 +346,7 @@
                         processPortAdded(port);
                     });
 
-            PORT_NAME_PREFIX_MAP.values().forEach(portNamePrefix -> {
+            portNamePrefixMap().values().forEach(portNamePrefix -> {
                 deviceService.getPorts(osNode.intgBridge()).stream()
                         .filter(port -> port.annotations().value(PORT_NAME)
                                 .startsWith(portNamePrefix) &&