SNMPv3 protocol support for onos.
Implement RFC-rfc3414 standard.
Change-Id: Ibe8d10aaaf569274b922a7500ed237a9813c0428
diff --git a/protocols/snmp/ctl/src/main/java/org/onosproject/snmp/ctl/DefaultSnmpController.java b/protocols/snmp/ctl/src/main/java/org/onosproject/snmp/ctl/DefaultSnmpController.java
index d5664e6..d84ef09 100644
--- a/protocols/snmp/ctl/src/main/java/org/onosproject/snmp/ctl/DefaultSnmpController.java
+++ b/protocols/snmp/ctl/src/main/java/org/onosproject/snmp/ctl/DefaultSnmpController.java
@@ -23,24 +23,28 @@
import com.btisystems.pronx.ems.core.snmp.SnmpSessionFactory;
import com.btisystems.pronx.ems.core.snmp.V2cSnmpConfiguration;
import com.google.common.base.Preconditions;
+import com.google.common.collect.Maps;
import org.onosproject.alarm.Alarm;
import org.onosproject.alarm.AlarmId;
import org.onosproject.alarm.DefaultAlarm;
import org.onosproject.net.DeviceId;
import org.onosproject.snmp.SnmpController;
import org.onosproject.snmp.SnmpDevice;
+import org.onosproject.snmp.SnmpException;
import org.osgi.service.component.ComponentContext;
import org.osgi.service.component.annotations.Activate;
import org.osgi.service.component.annotations.Component;
import org.osgi.service.component.annotations.Deactivate;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import org.snmp4j.mp.SnmpConstants;
import java.io.IOException;
import java.net.URI;
import java.util.Collection;
import java.util.HashMap;
import java.util.Map;
+import java.util.Objects;
import java.util.concurrent.ConcurrentHashMap;
/**
@@ -52,15 +56,18 @@
private final Logger log = LoggerFactory
.getLogger(getClass());
- protected ISnmpSessionFactory sessionFactory;
+ protected Map<Integer, ISnmpSessionFactory> factoryMap;
protected final Map<DeviceId, ISnmpSession> sessionMap = new HashMap<>();
protected final Map<DeviceId, SnmpDevice> snmpDeviceMap = new ConcurrentHashMap<>();
@Activate
public void activate(ComponentContext context) {
- sessionFactory = new SnmpSessionFactory(
- new DefaultSnmpConfigurationFactory(new V2cSnmpConfiguration()));
+ factoryMap = Maps.newHashMap();
+ factoryMap.put(SnmpConstants.version2c, new SnmpSessionFactory(
+ new DefaultSnmpConfigurationFactory(new V2cSnmpConfiguration())));
+ factoryMap.put(SnmpConstants.version3, new SnmpSessionFactory(
+ new DefaultSnmpConfigurationFactory(new V3SnmpConfiguration())));
log.info("Started");
}
@@ -76,6 +83,11 @@
public ISnmpSession getSession(DeviceId deviceId) throws IOException {
if (!sessionMap.containsKey(deviceId)) {
SnmpDevice device = snmpDeviceMap.get(deviceId);
+ ISnmpSessionFactory sessionFactory = factoryMap.get(device.getVersion());
+ if (Objects.isNull(sessionFactory)) {
+ log.error("Invalid session factory", deviceId);
+ throw new SnmpException("Invalid session factory");
+ }
String ipAddress = null;
int port = -1;
if (device != null) {
@@ -93,8 +105,26 @@
}
Preconditions.checkNotNull(ipAddress, "ip address is empty, cannot start session");
Preconditions.checkArgument(port != -1, "port is incorrect, cannot start session");
-
- ISnmpConfiguration config = new V2cSnmpConfiguration();
+ ISnmpConfiguration config;
+ if (device.getVersion() == SnmpConstants.version2c) {
+ config = new V2cSnmpConfiguration();
+ config.setCommunity(device.getCommunity());
+ } else if (device.getVersion() == SnmpConstants.version3) {
+ DefaultSnmpv3Device v3Device = (DefaultSnmpv3Device) device;
+ config = V3SnmpConfiguration.builder()
+ .setAddress(ipAddress)
+ .setSecurityName(v3Device.getSecurityName())
+ .setSecurityLevel(v3Device.getSecurityLevel())
+ .setAuthenticationProtocol(v3Device.getAuthProtocol())
+ .setAuthenticationPassword(v3Device.getAuthPassword())
+ .setPrivacyProtocol(v3Device.getPrivProtocol())
+ .setPrivacyPassword(v3Device.getPrivPassword())
+ .setContextName(v3Device.getContextName())
+ .build();
+ } else {
+ throw new SnmpException(
+ String.format("Invalid snmp version %d", device.getVersion()));
+ }
config.setPort(port);
sessionMap.put(deviceId, sessionFactory.createSession(config, ipAddress));
}