commit 9c9cde4d4d0a6508e7063445e332047177296b36
author Ray Milkey <ray@opennetworking.org> Fri Jan 12 14:22:06 2018 -0800
committer Thomas Vachuska <tom@opennetworking.org> Wed Jan 17 00:18:50 2018 +0000
tree d509a284328cb4f29ef20183fe0e8f7c5d7e9e3e
parent 57add212779b1896997486647439488042694d5a

SONAR Suggestion - protected members in final classes are pointless

Change-Id: Ie34d86aecf181e73867a14864d75e0db8a8f48f3

utils/misc/src/main/java/org/onlab/packet/IGMP.java

diff --git a/utils/misc/src/main/java/org/onlab/packet/IGMP.java b/utils/misc/src/main/java/org/onlab/packet/IGMP.java
index 3395f66..c8b5f85 100644
--- a/utils/misc/src/main/java/org/onlab/packet/IGMP.java
+++ b/utils/misc/src/main/java/org/onlab/packet/IGMP.java
@@ -32,7 +32,7 @@
  * Implements IGMP control packet format.
  */
 public abstract class IGMP extends BasePacket {
-    protected static final Logger log = getLogger(IGMP.class);
+    private static final Logger log = getLogger(IGMP.class);
 
     public static final byte TYPE_IGMPV3_MEMBERSHIP_QUERY = 0x11;
     public static final byte TYPE_IGMPV1_MEMBERSHIP_REPORT = 0x12;

utils/misc/src/main/java/org/onlab/util/BoundedThreadPool.java

diff --git a/utils/misc/src/main/java/org/onlab/util/BoundedThreadPool.java b/utils/misc/src/main/java/org/onlab/util/BoundedThreadPool.java
index a1f3e94..de5e1bd 100644
--- a/utils/misc/src/main/java/org/onlab/util/BoundedThreadPool.java
+++ b/utils/misc/src/main/java/org/onlab/util/BoundedThreadPool.java
@@ -39,7 +39,7 @@
 
     private static final org.slf4j.Logger log = LoggerFactory.getLogger(BoundedThreadPool.class);
 
-    protected static int maxQueueSize = 80_000; //TODO tune this value
+    static int maxQueueSize = 80_000; //TODO tune this value
     //private static final RejectedExecutionHandler DEFAULT_HANDLER = new CallerFeedbackPolicy();
     private static final long STATS_INTERVAL = 5_000; //ms
 

utils/misc/src/main/java/org/onlab/util/DefaultHashMap.java

diff --git a/utils/misc/src/main/java/org/onlab/util/DefaultHashMap.java b/utils/misc/src/main/java/org/onlab/util/DefaultHashMap.java
index 6523d56..ed5cf49 100644
--- a/utils/misc/src/main/java/org/onlab/util/DefaultHashMap.java
+++ b/utils/misc/src/main/java/org/onlab/util/DefaultHashMap.java
@@ -24,7 +24,7 @@
 public final class DefaultHashMap<K, V> extends HashMap<K, V> {
 
     /** Default value to return when no key binding exists. */
-    protected final V defaultValue;
+    private final V defaultValue;
 
     /**
      * Constructs an empty map with the given default value.

utils/misc/src/main/java/org/onlab/util/HexDump.java

diff --git a/utils/misc/src/main/java/org/onlab/util/HexDump.java b/utils/misc/src/main/java/org/onlab/util/HexDump.java
index b6759ed..692d688 100644
--- a/utils/misc/src/main/java/org/onlab/util/HexDump.java
+++ b/utils/misc/src/main/java/org/onlab/util/HexDump.java
@@ -26,7 +26,7 @@
  */
 @Deprecated
 public final class HexDump {
-    protected static final Logger log = LoggerFactory.getLogger(HexDump.class);
+    private static final Logger log = LoggerFactory.getLogger(HexDump.class);
 
     private HexDump() {
     }