| commit | 9c9cde4d4d0a6508e7063445e332047177296b36 | [log] [tgz] |
|---|---|---|
| author | Ray Milkey <ray@opennetworking.org> | Fri Jan 12 14:22:06 2018 -0800 |
| committer | Thomas Vachuska <tom@opennetworking.org> | Wed Jan 17 00:18:50 2018 +0000 |
| tree | d509a284328cb4f29ef20183fe0e8f7c5d7e9e3e | |
| parent | 57add212779b1896997486647439488042694d5a [diff] |
SONAR Suggestion - protected members in final classes are pointless Change-Id: Ie34d86aecf181e73867a14864d75e0db8a8f48f3
diff --git a/protocols/ospf/ctl/src/main/java/org/onosproject/ospf/controller/impl/OspfConfigUtil.java b/protocols/ospf/ctl/src/main/java/org/onosproject/ospf/controller/impl/OspfConfigUtil.java index b64b110..2173496 100644 --- a/protocols/ospf/ctl/src/main/java/org/onosproject/ospf/controller/impl/OspfConfigUtil.java +++ b/protocols/ospf/ctl/src/main/java/org/onosproject/ospf/controller/impl/OspfConfigUtil.java
@@ -47,7 +47,7 @@ public static final String ROUTERDEADINTERVAL = "routerDeadIntervalTime"; public static final String INTERFACETYPE = "interfaceType"; public static final String EXTERNALROUTINGCAPABILITY = "externalRoutingCapability"; - protected static final Logger log = LoggerFactory.getLogger(OspfConfigUtil.class); + private static final Logger log = LoggerFactory.getLogger(OspfConfigUtil.class); private static final String ISOPAQUE = "isOpaqueEnable"; /**
diff --git a/protocols/ospf/ctl/src/main/java/org/onosproject/ospf/controller/impl/OspfControllerImpl.java b/protocols/ospf/ctl/src/main/java/org/onosproject/ospf/controller/impl/OspfControllerImpl.java index ef09092..a9c3309 100644 --- a/protocols/ospf/ctl/src/main/java/org/onosproject/ospf/controller/impl/OspfControllerImpl.java +++ b/protocols/ospf/ctl/src/main/java/org/onosproject/ospf/controller/impl/OspfControllerImpl.java
@@ -47,7 +47,7 @@ @Service public class OspfControllerImpl implements OspfController { - protected static final Logger log = LoggerFactory.getLogger(OspfControllerImpl.class); + private static final Logger log = LoggerFactory.getLogger(OspfControllerImpl.class); private final Controller ctrl = new Controller(); @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY) protected DriverService driverService;
diff --git a/protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/LsaHeader.java b/protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/LsaHeader.java index 3de73fd..864a746 100644 --- a/protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/LsaHeader.java +++ b/protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/LsaHeader.java
@@ -52,7 +52,7 @@ LSA header format REFERENCE : RFC 2328 */ - protected static final Logger log = LoggerFactory.getLogger(LsaHeader.class); + public static final Logger log = LoggerFactory.getLogger(LsaHeader.class); private int age; private int options; private int lsType;