| commit | 9c9cde4d4d0a6508e7063445e332047177296b36 | [log] [tgz] |
|---|---|---|
| author | Ray Milkey <ray@opennetworking.org> | Fri Jan 12 14:22:06 2018 -0800 |
| committer | Thomas Vachuska <tom@opennetworking.org> | Wed Jan 17 00:18:50 2018 +0000 |
| tree | d509a284328cb4f29ef20183fe0e8f7c5d7e9e3e | |
| parent | 57add212779b1896997486647439488042694d5a [diff] |
SONAR Suggestion - protected members in final classes are pointless Change-Id: Ie34d86aecf181e73867a14864d75e0db8a8f48f3
diff --git a/protocols/isis/ctl/src/main/java/org/onosproject/isis/controller/impl/DefaultIsisController.java b/protocols/isis/ctl/src/main/java/org/onosproject/isis/controller/impl/DefaultIsisController.java index 60bb531..9cafc4c 100644 --- a/protocols/isis/ctl/src/main/java/org/onosproject/isis/controller/impl/DefaultIsisController.java +++ b/protocols/isis/ctl/src/main/java/org/onosproject/isis/controller/impl/DefaultIsisController.java
@@ -45,7 +45,7 @@ @Service public class DefaultIsisController implements IsisController { - protected static final Logger log = LoggerFactory.getLogger(DefaultIsisController.class); + private static final Logger log = LoggerFactory.getLogger(DefaultIsisController.class); private final Controller controller = new Controller(); @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY) protected DriverService driverService;
diff --git a/protocols/isis/isisio/src/main/java/org/onosproject/isis/io/isispacket/IsisMessageReader.java b/protocols/isis/isisio/src/main/java/org/onosproject/isis/io/isispacket/IsisMessageReader.java index c21fd3b..c1d5f81 100644 --- a/protocols/isis/isisio/src/main/java/org/onosproject/isis/io/isispacket/IsisMessageReader.java +++ b/protocols/isis/isisio/src/main/java/org/onosproject/isis/io/isispacket/IsisMessageReader.java
@@ -33,7 +33,7 @@ */ public class IsisMessageReader { - protected static final Logger log = LoggerFactory.getLogger(IsisMessageReader.class); + private static final Logger log = LoggerFactory.getLogger(IsisMessageReader.class); /** * Reads from ISIS packet from buffer.
diff --git a/protocols/isis/isisio/src/main/java/org/onosproject/isis/io/isispacket/tlv/TlvsToBytes.java b/protocols/isis/isisio/src/main/java/org/onosproject/isis/io/isispacket/tlv/TlvsToBytes.java index 66b3292..659ef57 100644 --- a/protocols/isis/isisio/src/main/java/org/onosproject/isis/io/isispacket/tlv/TlvsToBytes.java +++ b/protocols/isis/isisio/src/main/java/org/onosproject/isis/io/isispacket/tlv/TlvsToBytes.java
@@ -27,7 +27,7 @@ */ public final class TlvsToBytes { - protected static final Logger log = LoggerFactory.getLogger(TlvsToBytes.class); + private static final Logger log = LoggerFactory.getLogger(TlvsToBytes.class); /** * Creates an instance.
diff --git a/protocols/isis/isisio/src/main/java/org/onosproject/isis/io/isispacket/tlv/subtlv/SubTlvToBytes.java b/protocols/isis/isisio/src/main/java/org/onosproject/isis/io/isispacket/tlv/subtlv/SubTlvToBytes.java index d052bfc..a7bb08f 100644 --- a/protocols/isis/isisio/src/main/java/org/onosproject/isis/io/isispacket/tlv/subtlv/SubTlvToBytes.java +++ b/protocols/isis/isisio/src/main/java/org/onosproject/isis/io/isispacket/tlv/subtlv/SubTlvToBytes.java
@@ -27,7 +27,7 @@ */ public final class SubTlvToBytes { - protected static final Logger log = LoggerFactory.getLogger(SubTlvToBytes.class); + private static final Logger log = LoggerFactory.getLogger(SubTlvToBytes.class); /** * Creates an instance.