ONOS-3655 - Adding username and password support into the device key subsystem.
Change-Id: I196984479126ae3776093a0bded4b3c820a3eab8
diff --git a/incubator/api/src/test/java/org/onosproject/incubator/net/key/DeviceKeyTest.java b/incubator/api/src/test/java/org/onosproject/incubator/net/key/DeviceKeyTest.java
index 5a5699b..52e5e88 100644
--- a/incubator/api/src/test/java/org/onosproject/incubator/net/key/DeviceKeyTest.java
+++ b/incubator/api/src/test/java/org/onosproject/incubator/net/key/DeviceKeyTest.java
@@ -29,9 +29,11 @@
final String deviceKeyIdValue = "DeviceKeyId1";
final String deviceKeyLabel = "DeviceKeyLabel";
final String deviceKeySnmpName = "DeviceKeySnmpName";
+ final String deviceKeyUsername = "DeviceKeyUsername";
+ final String deviceKeyPassword = "DeviceKeyPassword";
/**
- * Checks the construction of a device key name with a null
+ * Checks the construction of a community name device key with a null
* value passed into it. This will throw a NullPointerException.
*/
@Test(expected = NullPointerException.class)
@@ -40,7 +42,7 @@
}
/**
- * Checks the construction of a device key name with non-null
+ * Checks the construction of a community name device key name with non-null
* values passed into it.
*/
@Test
@@ -58,4 +60,63 @@
assertNotNull("The communityName should not be null.", communityName);
assertEquals("The name should match as expected", deviceKeySnmpName, communityName.name());
}
+
+ /**
+ * Checks the invalid conversion a device key of type COMMUNITY_NAME to
+ * a username / password object.
+ */
+ @Test(expected = IllegalStateException.class)
+ public void testInvalidConversionToAsUsernamePassword() {
+ DeviceKeyId deviceKeyId = DeviceKeyId.deviceKeyId(deviceKeyIdValue);
+
+ DeviceKey deviceKey = DeviceKey.createDeviceKeyUsingCommunityName(deviceKeyId,
+ deviceKeyLabel, deviceKeySnmpName);
+ // Attempting to convert this device key to a username / password object
+ // should throw and IllegalStateException.
+ UsernamePassword usernamePassword = deviceKey.asUsernamePassword();
+ }
+
+ /**
+ * Checks the construction of a username / password device key with a null
+ * value passed into it. This will throw a NullPointerException.
+ */
+ @Test(expected = NullPointerException.class)
+ public void testCreateDeviceKeyUsingUsernamePasswordWithNull() {
+ DeviceKey deviceKey = DeviceKey.createDeviceKeyUsingUsernamePassword(null, null, null, null);
+ }
+
+ /**
+ * Checks the construction of a username and password device key name with non-null
+ * values passed into it.
+ */
+ @Test
+ public void testCreateDeviceKeyUsingUsernamePassword() {
+ DeviceKeyId deviceKeyId = DeviceKeyId.deviceKeyId(deviceKeyIdValue);
+
+ DeviceKey deviceKey = DeviceKey.createDeviceKeyUsingUsernamePassword(deviceKeyId, deviceKeyLabel,
+ deviceKeyUsername, deviceKeyPassword);
+ assertNotNull("The deviceKey should not be null.", deviceKey);
+ assertEquals("The deviceKeyId should match as expected", deviceKeyId, deviceKey.deviceKeyId());
+ assertEquals("The label should match as expected", deviceKeyLabel, deviceKey.label());
+ assertEquals("The type should match as expected", DeviceKey.Type.USERNAME_PASSWORD, deviceKey.type());
+
+ UsernamePassword usernamePassword = deviceKey.asUsernamePassword();
+ assertNotNull("The usernamePassword should not be null.", usernamePassword);
+ assertEquals("The username should match as expected", deviceKeyUsername, usernamePassword.username());
+ assertEquals("The password should match as expected", deviceKeyPassword, usernamePassword.password());
+ }
+
+ /**
+ * Checks the invalid conversion a device key of type USERNAME_PASSWORD to
+ * a community name object.
+ */
+ @Test(expected = IllegalStateException.class)
+ public void testInvalidConversionToAsCommunityName() {
+ DeviceKeyId deviceKeyId = DeviceKeyId.deviceKeyId(deviceKeyIdValue);
+
+ DeviceKey deviceKey = DeviceKey.createDeviceKeyUsingUsernamePassword(deviceKeyId, deviceKeyLabel,
+ deviceKeyUsername, deviceKeyPassword);
+ // Attempting to convert this device key to a community name should throw and IllegalStateException.
+ CommunityName communityName = deviceKey.asCommunityName();
+ }
}
diff --git a/incubator/api/src/test/java/org/onosproject/incubator/net/key/UsernamePasswordTest.java b/incubator/api/src/test/java/org/onosproject/incubator/net/key/UsernamePasswordTest.java
new file mode 100644
index 0000000..242a263
--- /dev/null
+++ b/incubator/api/src/test/java/org/onosproject/incubator/net/key/UsernamePasswordTest.java
@@ -0,0 +1,64 @@
+/*
+ * Copyright 2016 Open Networking Laboratory
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.onosproject.incubator.net.key;
+
+import org.junit.Test;
+
+import static org.junit.Assert.*;
+import static org.onlab.junit.ImmutableClassChecker.assertThatClassIsImmutable;
+
+/**
+ * Test class for UsernamePassword.
+ */
+public class UsernamePasswordTest {
+ final String username = "username";
+ final String password = "password";
+
+ /**
+ * Checks that the UsernamePassword class is immutable.
+ */
+ @Test
+ public void testImmutability() {
+ assertThatClassIsImmutable(UsernamePassword.class);
+ }
+
+ /**
+ * Checks the construction of a username / password object with null
+ * values passed into it.
+ */
+ @Test
+ public void testUsernamePasswordNull() {
+ UsernamePassword usernamePassword = UsernamePassword.usernamePassword(null, null);
+
+ assertNotNull("The UsernamePassword should not be null.", usernamePassword);
+ assertNull("The username should be null.", usernamePassword.username());
+ assertNull("The password should be null.", usernamePassword.password());
+ }
+
+ /**
+ * Checks the construction of a username / password object with non-null
+ * values passed into it.
+ */
+ @Test
+ public void testUsernamePassword() {
+ UsernamePassword usernamePassword = UsernamePassword.usernamePassword(username, password);
+
+ assertNotNull("The usernamePassword should not be null.", usernamePassword);
+ assertEquals("The username should match the expected value.", username, usernamePassword.username());
+ assertEquals("The password should match the expected value.", password, usernamePassword.password());
+ }
+}