[ONOS-7492] Add unit test for openstack router and subnet REST API
Change-Id: Icc6b1ce00e941b66c9027db7ec43b6568e323e76
diff --git a/apps/openstacknetworking/src/test/java/org/onosproject/openstacknetworking/web/OpenstackRouterWebResourceTest.java b/apps/openstacknetworking/src/test/java/org/onosproject/openstacknetworking/web/OpenstackRouterWebResourceTest.java
new file mode 100644
index 0000000..d0a24b3
--- /dev/null
+++ b/apps/openstacknetworking/src/test/java/org/onosproject/openstacknetworking/web/OpenstackRouterWebResourceTest.java
@@ -0,0 +1,320 @@
+/*
+ * Copyright 2018-present Open Networking Foundation
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.onosproject.openstacknetworking.web;
+
+import org.glassfish.jersey.server.ResourceConfig;
+import org.junit.Before;
+import org.junit.Test;
+import org.onlab.osgi.ServiceDirectory;
+import org.onlab.osgi.TestServiceDirectory;
+import org.onosproject.openstacknetworking.api.OpenstackRouterAdminService;
+import org.onosproject.rest.resources.ResourceTest;
+
+import javax.ws.rs.client.Entity;
+import javax.ws.rs.client.WebTarget;
+import javax.ws.rs.core.MediaType;
+import javax.ws.rs.core.Response;
+import java.io.InputStream;
+
+import static org.easymock.EasyMock.anyObject;
+import static org.easymock.EasyMock.anyString;
+import static org.easymock.EasyMock.createMock;
+import static org.easymock.EasyMock.expectLastCall;
+import static org.easymock.EasyMock.replay;
+import static org.easymock.EasyMock.verify;
+import static org.hamcrest.Matchers.is;
+import static org.junit.Assert.assertThat;
+
+/**
+ * Unit test for openstack router REST API.
+ */
+public class OpenstackRouterWebResourceTest extends ResourceTest {
+
+ final OpenstackRouterAdminService mockOpenstackRouterAdminService =
+ createMock(OpenstackRouterAdminService.class);
+ private static final String PATH = "routers";
+
+ /**
+ * Constructs an openstack router test instance.
+ */
+ public OpenstackRouterWebResourceTest() {
+ super(ResourceConfig.forApplicationClass(OpenstackNetworkingWebApplication.class));
+ }
+
+ /**
+ * Sets up the global values for all tests.
+ */
+ @Before
+ public void setUpTest() {
+ ServiceDirectory testDirectory =
+ new TestServiceDirectory()
+ .add(OpenstackRouterAdminService.class,
+ mockOpenstackRouterAdminService);
+ setServiceDirectory(testDirectory);
+ }
+
+ /**
+ * Tests the results of the REST API POST with creation operation.
+ */
+ @Test
+ public void testCreateRouterWithCreationOperation() {
+ mockOpenstackRouterAdminService.createRouter(anyObject());
+ replay(mockOpenstackRouterAdminService);
+
+ final WebTarget wt = target();
+ InputStream jsonStream = OpenstackRouterWebResourceTest.class
+ .getResourceAsStream("openstack-router.json");
+
+ Response response = wt.path(PATH).request(MediaType.APPLICATION_JSON_TYPE)
+ .post(Entity.json(jsonStream));
+ final int status = response.getStatus();
+
+ assertThat(status, is(201));
+
+ verify(mockOpenstackRouterAdminService);
+ }
+
+ /**
+ * Tests the results of the REST API POST with incorrect input.
+ */
+ @Test
+ public void testCreateRouterWithIncorrectInput() {
+ final WebTarget wt = target();
+ InputStream jsonStream = OpenstackRouterWebResourceTest.class
+ .getResourceAsStream("dummy.json");
+
+ Response response = wt.path(PATH).request(MediaType.APPLICATION_JSON_TYPE)
+ .post(Entity.json(jsonStream));
+ final int status = response.getStatus();
+
+ assertThat(status, is(400));
+ }
+
+ /**
+ * Tests the results of the REST API POST with duplicated router ID.
+ */
+ @Test
+ public void testCreateRouterWithDuplicatedId() {
+ mockOpenstackRouterAdminService.createRouter(anyObject());
+ expectLastCall().andThrow(new IllegalArgumentException());
+ replay(mockOpenstackRouterAdminService);
+
+ final WebTarget wt = target();
+ InputStream jsonStream = OpenstackRouterWebResourceTest.class
+ .getResourceAsStream("openstack-router.json");
+
+ Response response = wt.path(PATH).request(MediaType.APPLICATION_JSON_TYPE)
+ .post(Entity.json(jsonStream));
+ final int status = response.getStatus();
+
+ assertThat(status, is(400));
+
+ verify(mockOpenstackRouterAdminService);
+ }
+
+ /**
+ * Tests the results of the REST API PUT with updating operation.
+ */
+ @Test
+ public void testUpdateRouterWithUpdatingOperation() {
+ mockOpenstackRouterAdminService.updateRouter(anyObject());
+ replay(mockOpenstackRouterAdminService);
+
+ final WebTarget wt = target();
+ InputStream jsonStream = OpenstackRouterWebResourceTest.class
+ .getResourceAsStream("openstack-router.json");
+
+ Response response = wt.path(PATH + "/f49a1319-423a-4ee6-ba54-1d95a4f6cc68")
+ .request(MediaType.APPLICATION_JSON_TYPE)
+ .put(Entity.json(jsonStream));
+ final int status = response.getStatus();
+
+ assertThat(status, is(200));
+
+ verify(mockOpenstackRouterAdminService);
+ }
+
+ /**
+ * Tests the results of the REST API PUT with incorrect input.
+ */
+ @Test
+ public void testUpdateRouterWithIncorrectInput() {
+ final WebTarget wt = target();
+ InputStream jsonStream = OpenstackRouterWebResourceTest.class
+ .getResourceAsStream("dummy.json");
+
+ Response response = wt.path(PATH + "/f49a1319-423a-4ee6-ba54-1d95a4f6cc68")
+ .request(MediaType.APPLICATION_JSON_TYPE)
+ .put(Entity.json(jsonStream));
+ final int status = response.getStatus();
+
+ assertThat(status, is(400));
+ }
+
+ /**
+ * Tests the results of the REST API PUT with non-existing router ID.
+ */
+ @Test
+ public void testUpdateRouterWithNonexistId() {
+ mockOpenstackRouterAdminService.updateRouter(anyObject());
+ expectLastCall().andThrow(new IllegalArgumentException());
+ replay(mockOpenstackRouterAdminService);
+
+ final WebTarget wt = target();
+ InputStream jsonStream = OpenstackRouterWebResourceTest.class
+ .getResourceAsStream("openstack-router.json");
+
+ Response response = wt.path(PATH + "/f49a1319-423a-4ee6-ba54-1d95a4f6cc68")
+ .request(MediaType.APPLICATION_JSON_TYPE)
+ .put(Entity.json(jsonStream));
+ final int status = response.getStatus();
+
+ assertThat(status, is(400));
+
+ verify(mockOpenstackRouterAdminService);
+ }
+
+ /**
+ * Tests the results of the REST API DELETE with deletion operation.
+ */
+ @Test
+ public void testDeleteRouterWithDeletionOperation() {
+ mockOpenstackRouterAdminService.removeRouter(anyString());
+ replay(mockOpenstackRouterAdminService);
+
+ final WebTarget wt = target();
+
+ Response response = wt.path(PATH + "/f49a1319-423a-4ee6-ba54-1d95a4f6cc68")
+ .request(MediaType.APPLICATION_JSON_TYPE)
+ .delete();
+ final int status = response.getStatus();
+
+ assertThat(status, is(204));
+
+ verify(mockOpenstackRouterAdminService);
+ }
+
+ /**
+ * Tests the results of the REST API DELETE with non-existing router ID.
+ */
+ @Test
+ public void testDeleteRouterWithNonexistId() {
+ mockOpenstackRouterAdminService.removeRouter(anyString());
+ expectLastCall().andThrow(new IllegalArgumentException());
+ replay(mockOpenstackRouterAdminService);
+
+ final WebTarget wt = target();
+
+ Response response = wt.path(PATH + "/non-exist-id")
+ .request(MediaType.APPLICATION_JSON_TYPE)
+ .delete();
+ final int status = response.getStatus();
+
+ assertThat(status, is(400));
+
+ verify(mockOpenstackRouterAdminService);
+ }
+
+ /**
+ * Tests the results of the REST API PUT with adding a new router interface.
+ */
+ @Test
+ public void testAddRouterInterfaceWithAdditionOperation() {
+ mockOpenstackRouterAdminService.addRouterInterface(anyObject());
+ replay(mockOpenstackRouterAdminService);
+
+ final WebTarget wt = target();
+ InputStream jsonStream = OpenstackRouterWebResourceTest.class
+ .getResourceAsStream("openstack-router-interface.json");
+
+ Response response = wt.path(PATH + "/f49a1319-423a-4ee6-ba54-1d95a4f6cc68/add_router_interface")
+ .request(MediaType.APPLICATION_JSON_TYPE)
+ .put(Entity.json(jsonStream));
+ final int status = response.getStatus();
+
+ assertThat(status, is(200));
+
+ verify(mockOpenstackRouterAdminService);
+ }
+
+ /**
+ * Tests the results of the REST API PUT with non-existing router interface ID.
+ */
+ @Test
+ public void testAddRouterInterfaceWithNonexistId() {
+ mockOpenstackRouterAdminService.addRouterInterface(anyObject());
+ expectLastCall().andThrow(new IllegalArgumentException());
+ replay(mockOpenstackRouterAdminService);
+
+ final WebTarget wt = target();
+ InputStream jsonStream = OpenstackRouterWebResourceTest.class
+ .getResourceAsStream("openstack-router-interface.json");
+
+ Response response = wt.path(PATH + "/f49a1319-423a-4ee6-ba54-1d95a4f6cc68/add_router_interface")
+ .request(MediaType.APPLICATION_JSON_TYPE)
+ .put(Entity.json(jsonStream));
+ final int status = response.getStatus();
+
+ assertThat(status, is(400));
+
+ verify(mockOpenstackRouterAdminService);
+ }
+
+ /**
+ * Tests the results of the REST API DELETE with deletion operation.
+ */
+ @Test
+ public void testDeleteRouterInterfaceWithDeletionOperation() {
+ mockOpenstackRouterAdminService.removeRouterInterface(anyString());
+ replay(mockOpenstackRouterAdminService);
+
+ final WebTarget wt = target();
+ InputStream jsonStream = OpenstackRouterWebResourceTest.class
+ .getResourceAsStream("openstack-router-interface.json");
+
+ Response response = wt.path(PATH + "/f49a1319-423a-4ee6-ba54-1d95a4f6cc68/remove_router_interface")
+ .request(MediaType.APPLICATION_JSON_TYPE)
+ .put(Entity.json(jsonStream));
+ final int status = response.getStatus();
+
+ assertThat(status, is(200));
+
+ verify(mockOpenstackRouterAdminService);
+ }
+
+ /**
+ * Tests the results of the REST API DELETE with non-existing router interface ID.
+ */
+ @Test
+ public void testDeleteRouterInterfaceWithNonexistId() {
+ mockOpenstackRouterAdminService.removeRouterInterface(anyString());
+ expectLastCall().andThrow(new IllegalArgumentException());
+ replay(mockOpenstackRouterAdminService);
+
+ final WebTarget wt = target();
+ InputStream jsonStream = OpenstackRouterWebResourceTest.class
+ .getResourceAsStream("openstack-router-interface.json");
+
+ Response response = wt.path(PATH + "/f49a1319-423a-4ee6-ba54-1d95a4f6cc68/remove_router_interface")
+ .request(MediaType.APPLICATION_JSON_TYPE)
+ .put(Entity.json(jsonStream));
+ final int status = response.getStatus();
+
+ assertThat(status, is(400));
+
+ verify(mockOpenstackRouterAdminService);
+ }
+}